Skip to content

Commit a86a0e9

Browse files
authored
Merge pull request kubernetes#3250 from enj/enj/f/csr_duration_kep_ga_done
KEP-2784: CSR Duration: address all GA items
2 parents 5730f1b + 2f2acfa commit a86a0e9

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

keps/sig-auth/2784-csr-duration/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,16 +225,25 @@ during version skews (discussed below).
225225
#### GA
226226

227227
- Confirm with [cert-manager](https://github.com/jetstack/cert-manager/pull/3646) that the new functionality addresses their use case
228+
+ [cert-manager/cert-manager#4957](https://github.com/cert-manager/cert-manager/pull/4957) successfully added the use of the `spec.expirationSeconds` field
228229
- Confirm with [pinniped](https://pinniped.dev) that the new functionality addresses their use case
230+
+ The Pinniped maintainers confirmed via [vmware-tanzu/pinniped#1070](https://github.com/vmware-tanzu/pinniped/pull/1070)
231+
that the `spec.expirationSeconds` field was sufficient for their use case
229232
- Confirm that no other metrics are necessary
233+
+ No other metrics have been identified by the maintainers or requested by external actors
230234
- Wait one release after beta to allow bugs to be reported
235+
+ No bugs were reported over a two release period with multiple external actors consuming the new API field
231236
- Inform external signer implementations of the `spec.expirationSeconds` field
232237
+ [GCP controller manager](https://github.com/kubernetes/cloud-provider-gcp/blob/ce127135e3b5c71893afc4dbf996bb3144eea81e/cmd/gcp-controller-manager/csr_signer.go)
238+
* Jordan Liggitt confirmed that GKE successfully updated their internal webhook based signer to honor the `spec.expirationSeconds` field
233239
+ [open-ness/edgeservices](https://github.com/open-ness/edgeservices/blob/e5f79c877a7fb16ee6078855a4674dcf0a23bf80/pkg/certsigner/certsigner.go)
240+
* Opened [smart-edge-open/edgeservices#37](https://github.com/smart-edge-open/edgeservices/issues/37) to inform the maintainers of the `spec.expirationSeconds` field
234241
+ [SUSE/kucero](https://github.com/SUSE/kucero/blob/515e41a7599e518d8f39d79cd072ff443eb0de8f/pkg/pki/signer/signer.go)
242+
* [SUSE/kucero#34](https://github.com/SUSE/kucero/pull/34) successfully added the use of the `spec.expirationSeconds` field
235243
- Update conformance tests for the certificates API (`test/e2e/auth/certificates.go`) to assert that
236244
the `spec.expirationSeconds` field is persisted. We will not check if the field is honored as
237245
this functionality is optional.
246+
+ Addressed in [kubernetes/kubernetes#108782](https://github.com/kubernetes/kubernetes/pull/108782)
238247

239248
### Upgrade / Downgrade Strategy
240249

@@ -513,6 +522,7 @@ N/A
513522
- 1.22: 2021-07-02: Implementation [pull request](https://github.com/kubernetes/kubernetes/pull/99494) merged
514523
- 1.22: 2021-07-12: KEP updated with implementation details
515524
- 1.24: 2022-01-28: KEP updated with GA milestone details
525+
- 1.24: 2022-03-21: KEP updated with completed GA items
516526

517527
## Drawbacks
518528

0 commit comments

Comments
 (0)