You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-node/1972-kubelet-exec-probe-timeouts/README.md
+15-4Lines changed: 15 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -42,7 +42,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
42
42
43
43
Kubelet today does not respect exec probe timeouts. This is considered a bug we should fix since
44
44
the timeout value is supported in the Container Probe API. Because exec probe timeouts
45
-
were never respected by kubelet, a new feature gate `ExecProbeTimeouts` will be introduced.
45
+
were never respected by kubelet, a new feature gate `ExecProbeTimeout` will be introduced.
46
46
With this feature, nodes can be configured to preserve the current behavior while the proper
47
47
timeouts are enabled for exec probes.
48
48
@@ -69,8 +69,8 @@ Kubelet not respecting the probe timeout is a bug and should be fixed.
69
69
70
70
Changes to kubelet:
71
71
* Ensure kubelet handles timeout errors and registers them as failing probes.
72
-
* Add feature gate `ExecProbeTimeouts` that is GA and on by default.
73
-
* If the feature gate `ExecProbeTimeouts` is disabled and an exec probe timeout is reached, add warning logs to inform users that exec probes are timing out.
72
+
* Add feature gate `ExecProbeTimeout` that is GA and on by default.
73
+
* If the feature gate `ExecProbeTimeout` is disabled and an exec probe timeout is reached, add warning logs to inform users that exec probes are timing out.
* re-enable [existing exec liveness probe e2e test](https://github.com/kubernetes/kubernetes/blob/ea1458550077bdf3b26ac34551a3591d280fe1f5/test/e2e/common/container_probe.go#L210-L227) that is currently being skipped
81
81
* add new exec readiness probe e2e test.
82
+
* exec probe tests are promotes to Conformance ([#97619](https://github.com/kubernetes/kubernetes/pull/97619)).
82
83
83
84
### Graduation Criteria
84
85
85
86
This is a bug fix so the feature gate will be GA and on by default from the start.
86
87
88
+
The feature flag should be kept available till we get a sufficient evidence of people not being
89
+
affected by this bug fix - either directly (adjusting the timeouts in pod definition), or
90
+
indirectly, when the timeout is not specified in some third party templates and products
91
+
that cannot be easily fixed by end user.
92
+
93
+
Tentative timeline is to lock the feature flag to `true` in 1.22.
94
+
87
95
### Upgrade / Downgrade Strategy
88
96
89
97
N/A
@@ -95,6 +103,9 @@ N/A
95
103
## Implementation History
96
104
97
105
* 2020-09-08 - the KEP was merged as implementable for v1.20
106
+
* 2020-12-08 - Timeout is respected in [Kubernetes 1.20: The Raddest Release](https://kubernetes.io/blog/2020/12/08/kubernetes-1-20-release-announcement/),
107
+
and can be disabled with the feature flag
108
+
98
109
99
110
## Drawbacks
100
111
@@ -104,6 +115,6 @@ the timeout now may result in unexpected behavior for some workloads.
0 commit comments