Skip to content

Commit a9072eb

Browse files
authored
Merge pull request kubernetes#2294 from SergeyKanzhelev/execProbetimeOutSmallUpdates
Updated graduation criteria for ExecProbeTimeout removal
2 parents 8433cac + b77357a commit a9072eb

File tree

1 file changed

+15
-4
lines changed
  • keps/sig-node/1972-kubelet-exec-probe-timeouts

1 file changed

+15
-4
lines changed

keps/sig-node/1972-kubelet-exec-probe-timeouts/README.md

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
4242

4343
Kubelet today does not respect exec probe timeouts. This is considered a bug we should fix since
4444
the timeout value is supported in the Container Probe API. Because exec probe timeouts
45-
were never respected by kubelet, a new feature gate `ExecProbeTimeouts` will be introduced.
45+
were never respected by kubelet, a new feature gate `ExecProbeTimeout` will be introduced.
4646
With this feature, nodes can be configured to preserve the current behavior while the proper
4747
timeouts are enabled for exec probes.
4848

@@ -69,8 +69,8 @@ Kubelet not respecting the probe timeout is a bug and should be fixed.
6969

7070
Changes to kubelet:
7171
* Ensure kubelet handles timeout errors and registers them as failing probes.
72-
* Add feature gate `ExecProbeTimeouts` that is GA and on by default.
73-
* If the feature gate `ExecProbeTimeouts` is disabled and an exec probe timeout is reached, add warning logs to inform users that exec probes are timing out.
72+
* Add feature gate `ExecProbeTimeout` that is GA and on by default.
73+
* If the feature gate `ExecProbeTimeout` is disabled and an exec probe timeout is reached, add warning logs to inform users that exec probes are timing out.
7474
* Re-enable existing exec liveness probe e2e test.
7575
* Add new exec readiness probe e2e test.
7676

@@ -79,11 +79,19 @@ Changes to kubelet:
7979
E2E tests:
8080
* re-enable [existing exec liveness probe e2e test](https://github.com/kubernetes/kubernetes/blob/ea1458550077bdf3b26ac34551a3591d280fe1f5/test/e2e/common/container_probe.go#L210-L227) that is currently being skipped
8181
* add new exec readiness probe e2e test.
82+
* exec probe tests are promotes to Conformance ([#97619](https://github.com/kubernetes/kubernetes/pull/97619)).
8283

8384
### Graduation Criteria
8485

8586
This is a bug fix so the feature gate will be GA and on by default from the start.
8687

88+
The feature flag should be kept available till we get a sufficient evidence of people not being
89+
affected by this bug fix - either directly (adjusting the timeouts in pod definition), or
90+
indirectly, when the timeout is not specified in some third party templates and products
91+
that cannot be easily fixed by end user.
92+
93+
Tentative timeline is to lock the feature flag to `true` in 1.22.
94+
8795
### Upgrade / Downgrade Strategy
8896

8997
N/A
@@ -95,6 +103,9 @@ N/A
95103
## Implementation History
96104

97105
* 2020-09-08 - the KEP was merged as implementable for v1.20
106+
* 2020-12-08 - Timeout is respected in [Kubernetes 1.20: The Raddest Release](https://kubernetes.io/blog/2020/12/08/kubernetes-1-20-release-announcement/),
107+
and can be disabled with the feature flag
108+
98109

99110
## Drawbacks
100111

@@ -104,6 +115,6 @@ the timeout now may result in unexpected behavior for some workloads.
104115
## Alternatives
105116

106117
Some alternatives that were considered:
118+
107119
1. Increasing the default timeout for exec probes
108120
2. Continuing to ignore the exec probe timeout
109-

0 commit comments

Comments
 (0)