Skip to content

Commit a96e14f

Browse files
committed
KEP-2086: propose a metric for counting total Services that are blackholing traffic
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent c303e11 commit a96e14f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

keps/sig-network/2086-service-internal-traffic-policy/README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ Beta:
168168
* consensus on how internalTrafficPolicy overlaps with topology-aware routing.
169169

170170
GA:
171-
* metrics for if a Service is dropping local traffic due to no endpoints (a.k.a black hole)
171+
* metrics for total number of Services that are dropping local traffic (kubeproxy/sync_proxy_rules_blackhole_total) due to no endpoints (a.k.a black hole).
172172
* consensus on whether or not "PreferLocal" should be included as a new policy type
173173

174174
### Upgrade / Downgrade Strategy
@@ -242,9 +242,7 @@ _This section must be completed when targeting beta graduation to a release._
242242
* **How can an operator determine if the feature is in use by workloads?**
243243

244244
* Check Service to see if `internalTrafficPolicy` is set to `Local`.
245-
* A per-node "blackhole" metric will be added to kube-proxy which represent Services that are being intentionally dropped (internalTrafficPolicy=Local and no endpoints).
246-
247-
TODO: add metric name once it's decided
245+
* A per-node "blackhole" metric will be added to kube-proxy which represent Services that are being intentionally dropped (internalTrafficPolicy=Local and no endpoints). The metric will be named `kubeproxy/sync_proxy_rules/blackhole_total` (subject to rename).
248246

249247
* **What are the SLIs (Service Level Indicators) an operator can use to determine
250248
the health of the service?**

keps/sig-network/2086-service-internal-traffic-policy/kep.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,6 @@ feature-gates:
3939
- kube-apiserver
4040
- kube-proxy
4141
disable-supported: true
42+
43+
metrics:
44+
- kubeproxy/sync_proxy_rules_blackhole_total

0 commit comments

Comments
 (0)