Skip to content

Commit abc1121

Browse files
committed
DefaultPodTopologySpread graduation to Stable
1 parent 875dc3f commit abc1121

File tree

3 files changed

+33
-9
lines changed

3 files changed

+33
-9
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
kep-number: 1258
2+
beta:
3+
approver: "@wojtek-t"
4+
stable:
5+
approver: "@wojtek-t"

keps/sig-scheduling/1258-default-pod-topology-spread/README.md

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
- [Graduation Criteria](#graduation-criteria)
2626
- [Alpha (v1.19):](#alpha-v119)
2727
- [Beta (v1.20):](#beta-v120)
28+
- [Stable (v1.24):](#stable-v124)
2829
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
2930
- [Feature Enablement and Rollback](#feature-enablement-and-rollback)
3031
- [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning)
@@ -276,11 +277,18 @@ To ensure this feature to be rolled out in high quality. Following tests are man
276277

277278
#### Beta (v1.20):
278279

279-
- [ ] Finalize implementation:
280-
- [ ] Map `SelectorSpreadingPriority` to `PodTopologySpread` when using Policy API.
281-
- [ ] Provide knob for disabling the k8s default constraints.
282-
- [ ] Integration tests.
283-
- [ ] Verify conformance tests passing.
280+
- [X] Finalize implementation:
281+
- [X] Map `SelectorSpreadingPriority` to `PodTopologySpread` when using Policy API.
282+
- [X] Provide knob for disabling the k8s default constraints.
283+
- [X] Integration tests.
284+
- [X] Verify conformance tests passing.
285+
286+
#### Stable (v1.24):
287+
288+
- [X] No negative feedback.
289+
- Issue [#102136](https://github.com/kubernetes/kubernetes/issues/102136) has been fixed and backported.
290+
- [X] [Integration test](https://k8s-testgrid.appspot.com/presubmits-kubernetes-blocking#pull-kubernetes-integration&include-filter-by-regex=TestDefaultPodTopologySpread).
291+
- [X] [E2E test]( https://testgrid.k8s.io/sig-scheduling#sig-scheduling-kind,%20multizone&include-filter-by-regex=Multi-AZ)
284292

285293
## Production Readiness Review Questionnaire
286294

@@ -359,14 +367,24 @@ To ensure this feature to be rolled out in high quality. Following tests are man
359367
* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
360368
fields of API types, flags, etc.?**
361369

362-
TBD for GA.
370+
No.
363371

364372
### Monitoring Requirements
365373

366374
* **How can an operator determine if the feature is in use by workloads?**
367375

368376
All Pods are affected, unless they have explicit spreading constraints (.spec.topologySpreadConstraints).
369377

378+
* **How can someone using this feature know that it is working for their instance?**
379+
380+
- [ ] Events
381+
- Event Reason:
382+
- [ ] API .status
383+
- Condition name:
384+
- Other field:
385+
- [X] Other (treat as last resort)
386+
- Details: observe the scheduled pods and verify the spreading is satisfied.
387+
370388
* **What are the SLIs (Service Level Indicators) an operator can use to determine
371389
the health of the service?**
372390

@@ -471,6 +489,7 @@ If startup latency is in violation, there is the possibility that it's due to th
471489
- 2020-01-20: KEP updated to make use of framework's PluginConfig.
472490
- 2020-05-04: Update completed tasks and target alpha for 1.19.
473491
- 2020-09-21: Add Beta graduation criteria and PRR.
492+
- 2022-01-08: Graduate the feature to GA.
474493

475494
## Alternatives
476495

keps/sig-scheduling/1258-default-pod-topology-spread/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ prr-approvers:
1515
- "@wojtek-t"
1616
see-also:
1717
- "/keps/sig-scheduling/895-pod-topology-spread"
18-
stage: beta
19-
latest-milestone: "v1.20"
18+
stage: stable
19+
latest-milestone: "v1.24"
2020
milestone:
2121
alpha: "v1.19"
2222
beta: "v1.20"
23-
stable: "v1.22"
23+
stable: "v1.24"
2424
feature-gates:
2525
- name: DefaultPodTopologySpread
2626
components:

0 commit comments

Comments
 (0)