14
14
- [ API] ( #api )
15
15
- [ Risks and Mitigations] ( #risks-and-mitigations )
16
16
- [ Security] ( #security )
17
- - [ Debugability ] ( #debugability )
17
+ - [ Debuggability ] ( #debuggability )
18
18
- [ Performance] ( #performance )
19
19
- [ Design Details] ( #design-details )
20
20
- [ Test Plan] ( #test-plan )
@@ -261,8 +261,9 @@ manipulating match rules, namespace selector, or object selector (or reroute the
261
261
262
262
** Risk: Logic error in match condition expression.**
263
263
264
- Currently the match conditions must be encoded in the webhook backend itself. Moving the logic
265
- into a CEL expression does not materially increase the risk of a logic bug.
264
+ Currently the match conditions must be encoded in the webhook backend itself. Moving the logic into
265
+ a CEL expression adds a potential failure point. This can be mitigated by testing, but the CEL
266
+ ecosystem currently lacks some of the tools that would make this easier.
266
267
267
268
Of particular significance are match conditions tied to non-functional properties of an object, such
268
269
as using labels to decide whether to opt an object out of a policy. Without additional admition
@@ -275,7 +276,7 @@ is relevant.
275
276
These risks are inherent to the feature being proposed and cannot be mitigated through technical
276
277
means, but should be highlighted in the documentation.
277
278
278
- #### Debugability
279
+ #### Debuggability
279
280
280
281
We do not normally log, audit, or emit an event when a webhook is out-of-scope for a request, and
281
282
the same will _ mostly_ be true for match conditions.
@@ -519,8 +520,9 @@ remains unchanged.
519
520
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
520
521
521
522
Yes. Disabling the feature gate will ignore any ` matchConditions ` set, and return to the default
522
- behavior. This could increase the traffic to the webhook, and potentially increase the error rate if
523
- the webhook is down or rejects those requests.
523
+ behavior. Disabling ` AdmissionWebhookMatchConditions ` could increase the traffic to the webhook, and
524
+ potentially increase the error rate if the webhook fails to process the additional requests
525
+ correctly.
524
526
525
527
###### What happens if we reenable the feature if it was previously rolled back?
526
528
0 commit comments