Skip to content

Commit b8309a5

Browse files
Clarify existing integration tests
1 parent 97bedd0 commit b8309a5

File tree

1 file changed

+9
-8
lines changed
  • keps/sig-apps/2307-job-tracking-without-lingering-pods

1 file changed

+9
-8
lines changed

keps/sig-apps/2307-job-tracking-without-lingering-pods/README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
- [How can a rollout fail? Can it impact already running workloads?](#how-can-a-rollout-fail-can-it-impact-already-running-workloads)
3838
- [What specific metrics should inform a rollback?](#what-specific-metrics-should-inform-a-rollback)
3939
- [Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?](#were-upgrade-and-rollback-tested-was-the-upgrade-downgrade-upgrade-path-tested)
40-
- [Is the rollout accompanied by any deprecations and/or removals of features, APIs,](#is-the-rollout-accompanied-by-any-deprecations-andor-removals-of-features-apis)
40+
- [Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?](#is-the-rollout-accompanied-by-any-deprecations-andor-removals-of-features-apis-fields-of-api-types-flags-etc)
4141
- [Monitoring Requirements](#monitoring-requirements)
4242
- [How can an operator determine if the feature is in use by workloads?](#how-can-an-operator-determine-if-the-feature-is-in-use-by-workloads)
4343
- [What are the reasonable SLOs (Service Level Objectives) for the enhancement?](#what-are-the-reasonable-slos-service-level-objectives-for-the-enhancement)
@@ -317,6 +317,7 @@ the owner reference.
317317
- Job tracking with feature enabled.
318318
- Tracking of terminating Pods.
319319
- Transition from feature enabled to disabled and enabled again.
320+
- Clean up finalizers of Orphan Pods.
320321
- Tracking Jobs with big number of Pods, making sure the status is eventually
321322
consistent.
322323
- E2E test:
@@ -430,7 +431,8 @@ No implications to node runtime.
430431

431432
#### Are there any tests for feature enablement/disablement?**
432433

433-
Yes, we plan to add integration tests.
434+
Yes, we have [integration tests](https://github.com/kubernetes/kubernetes/blob/7a0638da76cb9843def65708b661d2c6aa58ed5a/test/integration/job/job_test.go)
435+
for feature enabled, disabled and transitions.
434436

435437
### Rollout, Upgrade and Rollback Planning
436438

@@ -449,14 +451,13 @@ No implications to node runtime.
449451

450452
#### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
451453

452-
Integration tests cover feature gate disablement.
454+
Integration tests cover feature gate disablement and re-enablement.
453455

454-
A manual upgrade->downgrade->upgrade flow will be executed prior to graduation
455-
to ensure that a running Job falls back to tracking without finalizers. The
456-
KEP will be updated with the findings of the test.
456+
A manual upgrade->downgrade->upgrade flow will be executed prior to Beta
457+
graduation to ensure that a running Job falls back to tracking without
458+
finalizers. The KEP will be updated with the findings of the test.
457459

458-
#### Is the rollout accompanied by any deprecations and/or removals of features, APIs,
459-
fields of API types, flags, etc.?
460+
#### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
460461

461462
No.
462463

0 commit comments

Comments
 (0)