Skip to content

Commit c1c7040

Browse files
authored
Merge pull request kubernetes#1942 from logicalhan/update-migration
Update metric migration KEP with relevant PRs and current status
2 parents dd5d81a + b2ac5bb commit c1c7040

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

keps/sig-instrumentation/20190605-metrics-stability-migration.md

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ approvers:
2121
- "@brancz"
2222
creation-date: 2019-06-05
2323
last-updated: 2019-06-27
24-
status: implementable
24+
status: implemented
2525
see-also:
2626
- 20181106-kubernetes-metrics-overhaul
2727
- 20190404-kubernetes-control-plane-metrics-stability
@@ -106,25 +106,25 @@ The [metrics overhaul KEP](https://github.com/kubernetes/enhancements/blob/maste
106106
## Implementation History
107107

108108
- [x] [Migrate kubelet metrics to use standard prometheus collectors](https://github.com/kubernetes/kubernetes/issues/79286)
109-
- [ ] Create migrated variants of shared client metrics
110-
- [ ] Create migrated variants of shared leader-election metrics
111-
- [ ] Create migrated variants of shared workqueue metrics
112-
- [ ] Migrate kubelet's /metrics/probes endpoint
113-
- [ ] Migrate apiserver /metrics endpoint
114-
- [ ] Migrate scheduler /metrics endpoint
115-
- [ ] Migrate kube-proxy /metrics endpoint
116-
- [ ] Migrate controller-manager /metrics endpoint (this include in-tree cloud-provider metrics)
109+
- [x] Create [migrated variants of shared client metrics](https://github.com/kubernetes/kubernetes/pull/81173)
110+
- [x] Create [migrated variants of shared leader-election metrics](https://github.com/kubernetes/kubernetes/pull/81173)
111+
- [x] Create [migrated variants of shared workqueue metrics](https://github.com/kubernetes/kubernetes/pull/81173)
112+
- [x] Migrate [kubelet's /metrics/probes endpoint](https://github.com/kubernetes/kubernetes/pull/81534)
113+
- [x] Migrate [apiserver /metrics endpoint](https://github.com/kubernetes/kubernetes/pull/81531)
114+
- [x] Migrate [scheduler /metrics endpoint](https://github.com/kubernetes/kubernetes/pull/81576)
115+
- [x] Migrate [kube-proxy /metrics endpoint](https://github.com/kubernetes/kubernetes/pull/81626)
116+
- [x] Migrate [controller-manager /metrics endpoint (this include in-tree cloud-provider metrics)](https://github.com/kubernetes/kubernetes/pull/81624)
117117

118118
TBD (since this is not yet implemented)
119119

120120
## Graduation Criteria
121121

122-
- [ ] Prior to migrating a component, automated static analysis testing is in place to validate and verify API guarantees.
123-
- [ ] Adequate documentation exists for new flags on components.
124-
- [ ] Update instrumentation documents to reflect changes
122+
- [x] Prior to migrating a [component, automated static analysis testing](https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190605-metrics-validation-and-verification.md) is in place to validate and verify API guarantees.
123+
- [x] Adequate [documentation exists for new flags on components](https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/)
124+
- [x] Update [instrumentation documents to reflect changes](https://github.com/kubernetes/website/pull/17578)
125125

126126
## Testing Plan
127127

128-
- [ ] Prior to migrating a metric's endpoint, we will run local tests to verify that the same metrics are populated
129-
- [ ] All metrics framework code will have unit/integration tests
130-
- [ ] All validation and verification code will have unit/integration tests
128+
- [x] Prior to migrating a metric's endpoint, we will run local tests to verify that the same metrics are populated
129+
- [x] All metrics framework code will have unit/integration tests
130+
- [x] All validation and verification code will have unit/integration tests

0 commit comments

Comments
 (0)