Skip to content

Commit c41c17e

Browse files
author
Han Kang
committed
update to address wojtek's comments
1 parent 3ad350b commit c41c17e

File tree

1 file changed

+6
-4
lines changed
  • keps/sig-instrumentation/3466-kubernetes-component-health-slis

1 file changed

+6
-4
lines changed

keps/sig-instrumentation/3466-kubernetes-component-health-slis/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,13 +250,13 @@ without any issues.
250250

251251
##### Integration tests
252252

253-
- [X] ensure existence of healthcheck endpoint (beta requirement)
253+
- [ ] ensure existence of healthcheck endpoint (beta requirement)
254254

255255
- <test>: <link to test coverage>
256256

257257
##### e2e tests
258258

259-
- [X] ensure existence of healthcheck endpoint (beta requirement)
259+
- [ ] ensure existence of healthcheck endpoint (beta requirement)
260260

261261
- <test>: <link to test coverage>
262262

@@ -336,8 +336,7 @@ We will target this feature behind a flag `ComponentSLIs`
336336

337337
###### How can this feature be enabled / disabled in a live cluster?
338338

339-
340-
- [X] Feature gate (also fill in values in `kep.yaml`)
339+
- [ ] Feature gate (also fill in values in `kep.yaml`)
341340
- Feature gate name: `ComponentSLIs`
342341
- Components depending on the feature gate:
343342
+ apiserver
@@ -346,6 +345,9 @@ We will target this feature behind a flag `ComponentSLIs`
346345
+ controller-manager
347346
+ kube-proxy
348347

348+
###### Are there any tests for feature enablement/disablement?
349+
350+
Given this feature is purely in-memory, no enablement/disablement tests are needed.
349351

350352
###### Does enabling the feature change any default behavior?
351353

0 commit comments

Comments
 (0)