Skip to content

Commit cb8e5ac

Browse files
committed
Apply feedback
1 parent a9ca9a8 commit cb8e5ac

File tree

1 file changed

+8
-5
lines changed
  • keps/sig-api-machinery/3488-cel-admission-control

1 file changed

+8
-5
lines changed

keps/sig-api-machinery/3488-cel-admission-control/README.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,9 @@ responsibilities across resources. The resources involved are:
361361

362362
![Relatinships between policy resources](erd.png)
363363

364-
This allows for a N:N relationship between policy definitions and the configuration of those policies. This separation has already been
365-
demonstrated successfully by multiple policy frameworks (see the survey further down in this KEP). It has a few key properties:
364+
This separation has already been demonstrated successfully by multiple policy
365+
frameworks (see the survey further down in this KEP). It has a few key
366+
properties:
366367

367368
- Reduces total amount of resource data needed to manage policies:
368369
- Params can be shared across multiple policies instead of copied. Multiple
@@ -474,6 +475,7 @@ spec:
474475
- key: environment,
475476
operator: NotIn,
476477
values: ["test"]
478+
mode: Enabled
477479
```
478480

479481
```yaml
@@ -500,6 +502,7 @@ spec:
500502
namespaceSelectors:
501503
- key: environment,
502504
operator: Exists
505+
mode: Enabled
503506
```
504507

505508
With this binding, the test and global policy bindings overlap. Resources
@@ -1018,7 +1021,7 @@ spec:
10181021
- expression: "object.spec.replicas < 100"
10191022
singletonBinding:
10201023
matchResources: ...
1021-
enablement: Enabled
1024+
mode: Enabled
10221025
```
10231026

10241027
Note that:
@@ -1532,8 +1535,8 @@ functions like `labelSelector.match()`.
15321535
#### Use Case: Fine grained control of enforcement
15331536

15341537
Policy author wishes to define a policy where the cluster administrator is able
1535-
to configure if the policy is enforced by a deny or if it is only ever used to
1536-
emit a warning.
1538+
to configure how a policy is enforced by defining a series of progressively
1539+
stricter levels.
15371540

15381541
Multiple copies of the same expression can be used, each guarded by a params
15391542
check:

0 commit comments

Comments
 (0)