Skip to content

Commit ccb4052

Browse files
committed
add specific metrics for insecure backend proxy for pod logs
1 parent 4e0c72b commit ccb4052

File tree

1 file changed

+4
-6
lines changed
  • keps/sig-api-machinery/1295-insecure-backend-proxy

1 file changed

+4
-6
lines changed

keps/sig-api-machinery/1295-insecure-backend-proxy/README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,16 +231,14 @@ fields of API types, flags, etc.?**
231231
### Monitoring Requirements
232232

233233
* **How can an operator determine if the feature is in use by workloads?**
234-
TODO!!!! Do we want a new metric measuring how often the flag is set?
235-
Ideally, this should be a metric. Operations against the Kubernetes API (e.g.,
236-
checking if there are objects with field X set) may be a last resort. Avoid
237-
logs or events for this purpose.
234+
`pods_logs_insecure_backend_total` has a label `skip_tls_allowed` which will count how often this value is set by clients.
238235

239236
* **What are the SLIs (Service Level Indicators) an operator can use to determine
240237
the health of the service?**
241238
- [ ] Metrics
242-
- Metric name: TODO!!!! find the metric that counts pods/logs errors
243-
- [Optional] Aggregation method:
239+
- Metric name:
240+
`pods_logs_insecure_backend_total` indicates usage.
241+
`pods_logs_backend_tls_failure_total` indicates how often usage of the option may have allowed a connection to be established.
244242
- Components exposing the metric: kube-apiserver
245243

246244
* **What are the reasonable SLOs (Service Level Objectives) for the above SLIs?**

0 commit comments

Comments
 (0)