Skip to content

Commit cf6306d

Browse files
committed
add notes about misunderstandings
1 parent 83ec184 commit cf6306d

File tree

1 file changed

+11
-2
lines changed
  • keps/sig-apps/2804-consolidate-workload-controllers-status

1 file changed

+11
-2
lines changed

keps/sig-apps/2804-consolidate-workload-controllers-status/README.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,13 @@ tags, and then generate with `hack/update-toc.sh`.
8787
- [Story 1](#story-1)
8888
- [Story 2](#story-2)
8989
- [Overview of all conditions](#overview-of-all-conditions)
90-
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
90+
- [Proposed Conditions](#proposed-conditions)
9191
- [Progressing](#progressing)
9292
- [Complete](#complete)
9393
- [Failed](#failed)
9494
- [Available](#available)
9595
- [Batch Workloads Conditions: Waiting & Running](#batch-workloads-conditions-waiting--running)
96+
- [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
9697
- [Risks and Mitigations](#risks-and-mitigations)
9798
- [Design Details](#design-details)
9899
- [Test Plan](#test-plan)
@@ -279,7 +280,7 @@ The following table gives an overview on what conditions each of the workload re
279280

280281
**\*\* CronJob does not even have Conditions field in its Status**
281282

282-
### Notes/Constraints/Caveats (Optional)
283+
### Proposed Conditions
283284

284285
<!--
285286
What are the caveats to the proposal?
@@ -359,6 +360,14 @@ Kubernetes marks a Job as `running` if there is at least one Pod with phase `Run
359360
This KEP does not introduce CronJob conditions as it is difficult to define conditions that would describe CronJob behaviour in useful manner.
360361
In case the user is interested if there are any running Jobs, `.status.active` field should be sufficient.
361362

363+
### Notes/Constraints/Caveats (Optional)
364+
365+
As observed in some issues (https://github.com/kubernetes/website/pull/31226) and talking to the users, there is a misunderstanding about the meaning of the `Progressing` condition. These include:
366+
- Thinking that the `Progressing` condition reflects the state of the current Deployment instead of the last rollout. Which includes expectation that the `Progressing` condition will keep checking availability of replicas and revert to `progressing`/`failed` state even after the `complete` state is reached. And that the progressing condition will thus also reflect any changes in scaling.
367+
- Confusion that ProgressDeadlineExceeded does not occur after the Deployment rollout completes when the availability of pods degrades before the `.spec.progressDeadlineSeconds` times out.
368+
369+
To summarize, the name of the `Progressing` condition doesn't indicate its true meaning that its main responsibility is the indication of rollouts, and it confuses the users.
370+
362371
### Risks and Mitigations
363372

364373
<!--

0 commit comments

Comments
 (0)