Skip to content

Commit d7f1a34

Browse files
authored
Merge pull request kubernetes#2538 from wojtek-t/update_efficient_watch_resumption_kep
Update KEP 1904 with upgrade test results
2 parents 20b2158 + dc6f648 commit d7f1a34

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

keps/sig-api-machinery/1904-efficient-watch-resumption/README.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,22 @@ _This section must be completed when targeting beta graduation to a release._
359359
Crashes of kube-apiserver.
360360

361361
* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
362-
Manual tests are still to be run.
362+
Manual tests were run in GKE Regional Cluster with 3 master nodes. No problems were
363+
identified during those tests (which no state is stored in etcd associated with this
364+
feature).
365+
366+
Additionally, an upgrade path was also tested in GKE Regional Cluster with 5000 nodes
367+
with the feature enabled. There is a tremendous positive impact on API call latency
368+
metrics:
369+
- [before] for many resources, even simple GET requests were spiking to 1m on 99th
370+
percentile
371+
- [after] we keep all resource and namespace scoped requests within SLO and just some
372+
cluster-scoped requests slightly exceeding the [SLO].
373+
374+
[before]: ./without_feature_metrics.png
375+
[after]: ./with_feature_metrics.png
376+
[SLO]: https://github.com/kubernetes/community/blob/master/sig-scalability/slos/api_call_latency.md
377+
363378

364379
* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
365380
fields of API types, flags, etc.?**
196 KB
Loading
208 KB
Loading

0 commit comments

Comments
 (0)