Skip to content

Commit db09efa

Browse files
committed
Add acknowledgement checkbox
1 parent f982ff9 commit db09efa

File tree

1 file changed

+6
-0
lines changed
  • keps/sig-storage/2268-non-graceful-shutdown

1 file changed

+6
-0
lines changed

keps/sig-storage/2268-non-graceful-shutdown/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,10 @@ To mitigate this we plan to have a high test coverage and to introduce this enha
146146

147147
### Test Plan
148148

149+
[x] I/we understand the owners of the involved components may require updates to
150+
existing tests to make this code solid enough prior to committing the changes necessary
151+
to implement this enhancement.
152+
149153
#### Prerequisite testing updates
150154

151155
There are existing tests for Pod GC controller: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/node/pod_gc.go
@@ -154,6 +158,7 @@ There are existing tests for attach detach controller. Creating a pod that uses
154158
Deleting a pod will trigger PVC to be detached: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/pod/delete.go
155159

156160
#### Unit tests
161+
157162
* Add unit tests to affected components in kube-controller-manager:
158163
* Add tests in Pod GC Controller for the new logic to clean up pods and the `out-of-service` taint.
159164
* Add tests in Attachdetach Controller for the changed logic that allow volumes to be forcefully detached without wait.
@@ -165,6 +170,7 @@ Add a test for forcefully terminating pods in https://github.com/kubernetes/kube
165170
Add a test for force detach without waiting for 6 minutes in https://github.com/kubernetes/kubernetes/blob/master/test/integration/volume/attach_detach_test.go
166171

167172
#### E2E tests
173+
168174
* New E2E tests to validate workloads move successfully to another running node when a node is shutdown.
169175
* Feature gate for `NodeOutOfServiceVolumeDetach` is disabled, feature is not active.
170176
* Feature gate for `NodeOutOfServiceVolumeDetach` is enabled. Add `out-of-service` taint after node is shutdown:

0 commit comments

Comments
 (0)