|
15 | 15 | - [Current Services ClusterIPs allocation model](#current-services-clusterips-allocation-model)
|
16 | 16 | - [Proposed Services ClusterIPs allocation model](#proposed-services-clusterips-allocation-model)
|
17 | 17 | - [Test Plan](#test-plan)
|
| 18 | + - [Unit tests](#unit-tests) |
18 | 19 | - [Graduation Criteria](#graduation-criteria)
|
19 | 20 | - [Alpha](#alpha)
|
20 | 21 | - [Beta](#beta)
|
@@ -281,6 +282,17 @@ type randomScanReservedStrategy struct {
|
281 | 282 | This feature doesn't modify the cluster behavior, only the order on which dynamic IP are assigned to Services,
|
282 | 283 | there is no need for e2e or integration tests, unit tests are enough.
|
283 | 284 |
|
| 285 | +
|
| 286 | +[x] I/we understand the owners of the involved components may require updates to |
| 287 | +existing tests to make this code solid enough prior to committing the changes necessary |
| 288 | +to implement this enhancement. |
| 289 | +
|
| 290 | +##### Unit tests |
| 291 | +
|
| 292 | +
|
| 293 | +- pkg/registry/core/service/allocator/bitmap_test.go - 84.2 |
| 294 | +- pkg/registry/core/service/ipallocator/allocator_test.go - 87 |
| 295 | +
|
284 | 296 | ### Graduation Criteria
|
285 | 297 |
|
286 | 298 | #### Alpha
|
@@ -421,33 +433,46 @@ The allocator using this feature will have a `dynamic_range_offset` value differ
|
421 | 433 |
|
422 | 434 | ###### Does this feature depend on any specific services running in the cluster?
|
423 | 435 |
|
| 436 | +No |
424 | 437 | ### Scalability
|
425 | 438 |
|
426 | 439 | ###### Will enabling / using this feature result in any new API calls?
|
427 | 440 |
|
428 |
| -
|
| 441 | +No |
429 | 442 | ###### Will enabling / using this feature result in introducing new API types?
|
430 | 443 |
|
| 444 | +No |
431 | 445 | ###### Will enabling / using this feature result in any new calls to the cloud provider?
|
432 | 446 |
|
| 447 | +No |
| 448 | +
|
433 | 449 | ###### Will enabling / using this feature result in increasing size or count of the existing API objects?
|
434 | 450 |
|
| 451 | +No |
435 | 452 | ###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
|
436 | 453 |
|
| 454 | +No |
437 | 455 | ###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
|
438 | 456 |
|
| 457 | +No |
439 | 458 | ### Troubleshooting
|
440 | 459 |
|
441 | 460 | ###### How does this feature react if the API server and/or etcd is unavailable?
|
442 | 461 |
|
| 462 | +N/A |
443 | 463 | ###### What are other known failure modes?
|
444 | 464 |
|
| 465 | +N/A |
| 466 | +
|
445 | 467 | ###### What steps should be taken if SLOs are not being met to determine the problem?
|
446 | 468 |
|
447 | 469 | ## Implementation History
|
448 | 470 |
|
| 471 | +
|
449 | 472 | ## Drawbacks
|
450 | 473 |
|
| 474 | +- v1.24 - Initial implementation https://github.com/kubernetes/kubernetes/pull/106792 |
| 475 | +- v1.25 - Beta |
451 | 476 | ## Alternatives
|
452 | 477 |
|
453 | 478 | - Replace current allocation implementation based on bitmaps https://github.com/kubernetes/enhancements/pull/1881
|
|
0 commit comments