Skip to content

Commit dec01d9

Browse files
authored
Merge pull request kubernetes#3413 from aojea/beta_services
promote ServiceIPStaticSubrange to beta
2 parents 97f9cf3 + fca4171 commit dec01d9

File tree

3 files changed

+30
-3
lines changed

3 files changed

+30
-3
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 3070
22
alpha:
33
approver: "@wojtek-t"
4+
beta:
5+
approver: "@johnbelamaric"

keps/sig-network/3070-reserved-service-ip-range/README.md

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
- [Current Services ClusterIPs allocation model](#current-services-clusterips-allocation-model)
1616
- [Proposed Services ClusterIPs allocation model](#proposed-services-clusterips-allocation-model)
1717
- [Test Plan](#test-plan)
18+
- [Unit tests](#unit-tests)
1819
- [Graduation Criteria](#graduation-criteria)
1920
- [Alpha](#alpha)
2021
- [Beta](#beta)
@@ -281,6 +282,17 @@ type randomScanReservedStrategy struct {
281282
This feature doesn't modify the cluster behavior, only the order on which dynamic IP are assigned to Services,
282283
there is no need for e2e or integration tests, unit tests are enough.
283284
285+
286+
[x] I/we understand the owners of the involved components may require updates to
287+
existing tests to make this code solid enough prior to committing the changes necessary
288+
to implement this enhancement.
289+
290+
##### Unit tests
291+
292+
293+
- pkg/registry/core/service/allocator/bitmap_test.go - 84.2
294+
- pkg/registry/core/service/ipallocator/allocator_test.go - 87
295+
284296
### Graduation Criteria
285297
286298
#### Alpha
@@ -421,33 +433,46 @@ The allocator using this feature will have a `dynamic_range_offset` value differ
421433
422434
###### Does this feature depend on any specific services running in the cluster?
423435
436+
No
424437
### Scalability
425438
426439
###### Will enabling / using this feature result in any new API calls?
427440
428-
441+
No
429442
###### Will enabling / using this feature result in introducing new API types?
430443
444+
No
431445
###### Will enabling / using this feature result in any new calls to the cloud provider?
432446
447+
No
448+
433449
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
434450
451+
No
435452
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
436453
454+
No
437455
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
438456
457+
No
439458
### Troubleshooting
440459
441460
###### How does this feature react if the API server and/or etcd is unavailable?
442461
462+
N/A
443463
###### What are other known failure modes?
444464
465+
N/A
466+
445467
###### What steps should be taken if SLOs are not being met to determine the problem?
446468
447469
## Implementation History
448470
471+
449472
## Drawbacks
450473
474+
- v1.24 - Initial implementation https://github.com/kubernetes/kubernetes/pull/106792
475+
- v1.25 - Beta
451476
## Alternatives
452477
453478
- Replace current allocation implementation based on bitmaps https://github.com/kubernetes/enhancements/pull/1881

keps/sig-network/3070-reserved-service-ip-range/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ approvers:
1414
- "@danwinship"
1515

1616
# The target maturity stage in the current dev cycle for this KEP.
17-
stage: alpha
17+
stage: beta
1818

1919
# The most recent milestone for which work toward delivery of this KEP has been
2020
# done. This can be the current (upcoming) milestone, if it is being actively
2121
# worked on.
22-
latest-milestone: "v1.24"
22+
latest-milestone: "v1.25"
2323

2424
# The milestone at which this feature was, or is targeted to be, at each stage.
2525
milestone:

0 commit comments

Comments
 (0)