Skip to content

Commit e7d196e

Browse files
committed
new metric to be added
Signed-off-by: Heba Elayoty <[email protected]>
1 parent d7c3edb commit e7d196e

File tree

1 file changed

+1
-4
lines changed
  • keps/sig-scheduling/3521-pod-scheduling-readiness

1 file changed

+1
-4
lines changed

keps/sig-scheduling/3521-pod-scheduling-readiness/README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -965,10 +965,7 @@ Pick one more of these and delete the rest.
965965
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
966966
implementation difficulties, etc.).
967967
-->
968-
Yes, we will need a new metric `pod_scheduling_excluding_preenqueue_duration_seconds` to explicitly differentiate whether the time spent during `PreEnqueue` is included or excluded.
969-
970-
This new metric is needed as users may get confused when using the `pod_scheduling_duration_seconds` metrics while scheduling gated condition exists. As the period of time when a Pod fails `PreEnqueue` (i.e.; gated) shouldn't be accounted in the `pod_scheduling_duration_seconds`.
971-
However, PreEnqueue does not always mean `SchedulingGates`, but only one case. Which means users may still want to include the time spent in `PreEnqueue`.
968+
Yes, a new metric `pod_scheduling_sli_duration_seconds` to explicitly revealing the SLI-related metric, it excludes the time spent during `PreEnqueue`.
972969

973970
### Dependencies
974971

0 commit comments

Comments
 (0)