@@ -105,7 +105,7 @@ for external plugins currently.
105
105
Because of starting as alpha and this is an explicitly opted-in feature, shadowing functionality will be hidden behind the environment variable
106
106
and will only be used after exporting;
107
107
``` sh
108
- export KUBECTL_ENABLE_ALPHA_CMD_SHADOW =true
108
+ export KUBECTL_ENABLE_CMD_SHADOW =true
109
109
```
110
110
111
111
### Notes/Constraints/Caveats
@@ -118,6 +118,11 @@ which other built-in commands will also be requested for this shadowing.
118
118
119
119
Security considerations are the same with executing other external plugins and there is no additional risk.
120
120
121
+ In terms of risk considerations, users may adopt external plugins that do not exist as subcommand(e.g. ` kubectl create foo ` ) but afterwards
122
+ built-in subcommand with the same name might be added. This brings about a risk about breaking users' scripts which
123
+ rely on external plugins. To overcome that problem, there should be a some form of forcing mechanism to select
124
+ external plugin instead built-in subcommand. ` KUBECTL_ENABLE_CMD_SHADOW ` flag can also be used also for that purpose
125
+ in later stages.
121
126
122
127
## Design Details
123
128
@@ -231,7 +236,7 @@ functionality is accessed.
231
236
Below are some examples to consider, in addition to the aforementioned [maturity levels][maturity-levels].
232
237
#### Alpha
233
238
234
- - Feature implemented behind a `KUBECTL_ENABLE_ALPHA_CMD_SHADOW =true` environment variable
239
+ - Feature implemented behind a `KUBECTL_ENABLE_CMD_SHADOW =true` environment variable
235
240
- Initial unit tests
236
241
237
242
#### Beta
@@ -262,7 +267,7 @@ in back-to-back releases.
262
267
-->
263
268
#### Alpha
264
269
265
- - Feature implemented behind a ` KUBECTL_ENABLE_ALPHA_CMD_SHADOW =true` environment variable
270
+ - Feature implemented behind a ` KUBECTL_ENABLE_CMD_SHADOW =true` environment variable
266
271
- Initial unit tests
267
272
268
273
#### Beta
@@ -352,7 +357,7 @@ well as the [existing list] of feature gates.
352
357
- Feature gate name:
353
358
- Components depending on the feature gate:
354
359
- [x] Other
355
- - Describe the mechanism: Exporting ` KUBECTL_ENABLE_ALPHA_CMD_SHADOW =true` environment variable will enable the feature
360
+ - Describe the mechanism: Exporting ` KUBECTL_ENABLE_CMD_SHADOW =true` environment variable will enable the feature
356
361
- Will enabling / disabling the feature require downtime of the control
357
362
plane? No
358
363
- Will enabling / disabling the feature require downtime or reprovisioning
0 commit comments