Skip to content

Commit eb1005f

Browse files
authored
Merge pull request kubernetes#2562 from pacoxu/update/cadvisor
[1.21]mark Disable CAdvisor Json Metrics as implemented
2 parents f879cd2 + 68baeb0 commit eb1005f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

keps/sig-node/2129-remove-cadvisor-json-metrics/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
3535
- [X] (R) Graduation criteria is in place
3636
- [X] (R) Production readiness review completed
37-
- [ ] Production readiness review approved
38-
- [ ] "Implementation History" section is up-to-date for milestone
37+
- [X] Production readiness review approved
38+
- [X] "Implementation History" section is up-to-date for milestone
3939
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
4040
- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
4141

@@ -174,6 +174,7 @@ Remove the `--enable-cadvisor-json-endpoints` flag and the kubelet stops serving
174174

175175
- 2020-10-04: Initial version of the KEP
176176
- 2021-02-04: Updates based on feedback
177+
- 2021-03-10: Implementation code complete in [kubernetes/kubernetes#99236](https://github.com/kubernetes/kubernetes/pull/99236)
177178

178179
## Drawbacks
179180

keps/sig-node/2129-remove-cadvisor-json-metrics/kep.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ authors:
44
- "@dashpole"
55
owning-sig: sig-node
66
participating-sigs: [sig-instrumentation]
7-
status: implementable
7+
status: implemented
88
creation-date: 2020-10-04
9+
last-updated: 2021-03-10
910
reviewers:
1011
- "derekwaynecarr"
1112
- "dawnchen"

0 commit comments

Comments
 (0)