Skip to content

Commit f1887d8

Browse files
authored
Merge pull request kubernetes#3603 from SergeyKanzhelev/swapReformatting
reformatting of a test plan
2 parents f10c264 + c7409b0 commit f1887d8

File tree

1 file changed

+87
-2
lines changed

1 file changed

+87
-2
lines changed

keps/sig-node/2400-node-swap/README.md

Lines changed: 87 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
- [KubeConfig addition](#kubeconfig-addition)
2424
- [CRI Changes](#cri-changes)
2525
- [Test Plan](#test-plan)
26+
- [Prerequisite testing updates](#prerequisite-testing-updates)
27+
- [Unit tests](#unit-tests)
28+
- [Integration tests](#integration-tests)
29+
- [e2e tests](#e2e-tests)
2630
- [Graduation Criteria](#graduation-criteria)
2731
- [Alpha](#alpha)
2832
- [Alpha2](#alpha2)
@@ -393,6 +397,79 @@ message LinuxContainerResources {
393397

394398
### Test Plan
395399

400+
<!--
401+
**Note:** *Not required until targeted at a release.*
402+
The goal is to ensure that we don't accept enhancements with inadequate testing.
403+
All code is expected to have adequate tests (eventually with coverage
404+
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
405+
when drafting this test plan.
406+
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
407+
-->
408+
409+
[X] I/we understand the owners of the involved components may require updates to
410+
existing tests to make this code solid enough prior to committing the changes necessary
411+
to implement this enhancement.
412+
413+
##### Prerequisite testing updates
414+
415+
<!--
416+
Based on reviewers feedback describe what additional tests need to be added prior
417+
implementing this enhancement to ensure the enhancements have also solid foundations.
418+
-->
419+
420+
All existing tests needs to pass with and without swap enabled.
421+
422+
##### Unit tests
423+
424+
<!--
425+
In principle every added code should have complete unit test coverage, so providing
426+
the exact set of tests will not bring additional value.
427+
However, if complete unit test coverage is not possible, explain the reason of it
428+
together with explanation why this is acceptable.
429+
-->
430+
431+
<!--
432+
Additionally, for Alpha try to enumerate the core package you will be touching
433+
to implement this enhancement and provide the current unit coverage for those
434+
in the form of:
435+
- <package>: <date> - <current test coverage>
436+
The data can be easily read from:
437+
https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
438+
This can inform certain test coverage improvements that we want to do before
439+
extending the production code to implement this enhancement.
440+
-->
441+
442+
This KEP introduces minor additions of memory swap controlling configuration parameters.
443+
444+
- Kubelet configuration parameters are tested in the package `k8s.io/kubernetes/pkg/kubelet/apis/config/validation`
445+
- Passing parameters to runtime is tested in `k8s.io/kubernetes/pkg/kubelet/kuberuntime`
446+
447+
Both packages has near 100% coverage and new functionality was covered.
448+
449+
In alpha2, tests will be extended in these packages to support kube-reserved swap settings.
450+
451+
452+
##### Integration tests
453+
454+
<!--
455+
This question should be filled when targeting a release.
456+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
457+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
458+
https://storage.googleapis.com/k8s-triage/index.html
459+
-->
460+
461+
No new tests added for Alpha and Alpha2 releases.
462+
463+
##### e2e tests
464+
465+
<!--
466+
This question should be filled when targeting a release.
467+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
468+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
469+
https://storage.googleapis.com/k8s-triage/index.html
470+
We expect no non-infra related flakes in the last month as a GA graduation criteria.
471+
-->
472+
396473
For alpha:
397474

398475
- Swap scenarios are enabled in test-infra for at least two Linux
@@ -402,14 +479,22 @@ For alpha:
402479
and further development efforts.
403480
- Focus should be on supported user stories as listed above.
404481

405-
For alpha2:
482+
Test grid tabs enabled:
483+
- [kubelet-gce-e2e-swap-ubuntu](https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-ubuntu): Green
484+
- [kubelet-gce-e2e-swap-ubuntu-serial](https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-ubuntu-serial): Green
485+
- [kubelet-gce-e2e-swap-fedora](https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-fedora): Degraded
486+
- [kubelet-gce-e2e-swap-fedora-serial](https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-fedora-serial): Degraded
487+
488+
No new e2e tests introduced.
489+
490+
For alpha2 [Current stage]:
406491

407492
- Add e2e tests that exercise all available swap configurations via the CRI.
408493
- Verify MemoryPressure behavior with swap enabled and document any changes
409494
for configuring eviction.
410495
- Verify new system-reserved settings for swap memory.
411496

412-
For beta:
497+
For beta [Future]:
413498

414499
- Add e2e tests that verify pod-level control of swap utilization.
415500
- Add e2e tests that verify swap performance with pods using a tmpfs.

0 commit comments

Comments
 (0)