Skip to content

Commit fd6109c

Browse files
nabokihmsenj
andauthored
Apply suggestions from code review
Co-authored-by: Mo Khan <[email protected]>
1 parent cd3c24e commit fd6109c

File tree

2 files changed

+3
-3
lines changed
  • keps

2 files changed

+3
-3
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
kep-number: 3225
22
alpha:
3-
approver: "@enj"
3+
approver: "@deads2k"

keps/sig-auth/3325-self-subject-attributes-review-api/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ The motivation for this KEP is to reduce obscurity and help users with debugging
7373

7474
## Proposal
7575

76-
Add a new API endpoint to the `authentication` group - `SelfSubjectAttributesReview`.
76+
Add a new API endpoint to the `authentication.k8s.io` group - `SelfSubjectAttributesReview`.
7777
The user will hit the endpoint after authentication happens, so all attributes will be available to return.
7878

7979
## Design Details
@@ -92,7 +92,7 @@ type SelfSubjectAttributesReview struct {
9292
// +optional
9393
metav1.ObjectMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"`
9494
// Status is filled in by the server with the user attributes.
95-
Status SelfSubjectAttributesReview `json:"status,omitempty" protobuf:"bytes,2,opt,name=status"`
95+
Status SelfSubjectAttributesReviewStatus `json:"status,omitempty" protobuf:"bytes,2,opt,name=status"`
9696
}
9797
```
9898
```go

0 commit comments

Comments
 (0)