Skip to content

Commit fe68421

Browse files
authored
Merge pull request kubernetes#3760 from dgrisonnet/383-update-scope
Update KEP-383 graduation criterias
2 parents 545228c + 4301eea commit fe68421

File tree

2 files changed

+4
-21
lines changed

2 files changed

+4
-21
lines changed

keps/sig-instrumentation/383-new-event-api-ga-graduation/README.md

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
- [Deprecated Fields](#deprecated-fields)
2626
- [Beta to GA Graduation](#beta-to-ga-graduation)
2727
- [Load Test](#load-test)
28-
- [Components Migration](#components-migration)
2928
- [Considerations](#considerations)
3029
- [Performance Impact](#performance-impact)
3130
- [Backward Compatibility](#backward-compatibility)
@@ -74,7 +73,7 @@ The KEP aims at fixing few issues in the current way Events are structured and i
7473

7574
Most sections and design details are copied from the original design doc: [Make Kubernetes Events Useful and Safe](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/events-redesign.md).
7675

77-
The new Event API has been promoted from v1beta1 to v1 in 1.19 and currently only scheduler was migrated to use it. This KEP proposes to graduate the new Event API by migrating all the remaining Kubernetes components to use the new Event API.
76+
The new Event API has been promoted from v1beta1 to v1 in 1.19 and currently only scheduler was migrated to use it.
7877

7978
## Motivation
8079

@@ -370,7 +369,7 @@ Scalability and Performance:
370369

371370
### Graduation Criteria
372371

373-
The new Event API is in v1 right now and scheduler has been migrated to use new API. The plan is to do a load test and migrate all the remaining components.
372+
The new Event API is in v1 right now and scheduler has been migrated to use new API. The plan is to do a load test before migrating all the remaining components.
374373

375374
#### Deprecated Fields
376375

@@ -383,27 +382,11 @@ This section lists the deprecated Event API fields that should be removed before
383382

384383
- Remove deprecated fields listed above
385384
- Gather data from performance and scalability tests
386-
- Remove all in-tree use of the core/v1.Event API in favour of events.k8s.io/v1
387385

388386
#### Load Test
389387

390388
The idea is to use [ClusterLoader](https://github.com/kubernetes/perf-tests/tree/master/clusterloader2) testing framework to do a load test to make sure events generated can be handled by etcd and there's no big performance reduction.
391389

392-
#### Components Migration
393-
394-
The list of components that need to be migrated is shown as follows:
395-
396-
- kubelet
397-
- cloud-controller-manager
398-
- kube-controller-manager
399-
- leader election
400-
- node problem detector
401-
- gce ingress controller
402-
- event exporter
403-
404-
(Note: there are more out-of-tree components that need to be migrated)
405-
406-
407390
## Considerations
408391

409392
### Performance Impact
@@ -745,4 +728,4 @@ We considered making easier for automated systems to use Events by enforcing "ac
745728

746729
### Pivoting Towards Making Events More Helpful for Cluster Operator During Debugging
747730

748-
We considered exposing more data that cluster operator would need to use Events for debugging, e.g. making ReportingController more central to the semantics of Event and adding some way to easily grep though the logs of appropriate component when looking for context of a given Event. This idea was dropped because Events are supposed to give application developer who's running his application on the cluster a rough understanding what was happening with his app.
731+
We considered exposing more data that cluster operator would need to use Events for debugging, e.g. making ReportingController more central to the semantics of Event and adding some way to easily grep though the logs of appropriate component when looking for context of a given Event. This idea was dropped because Events are supposed to give application developer who's running his application on the cluster a rough understanding what was happening with his app.

keps/sig-instrumentation/383-new-event-api-ga-graduation/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ approvers:
1515
- "@brancz"
1616
creation-date: 2019-01-31
1717
last-updated: 2021-02-03
18-
status: implementable
18+
status: implemented
1919
see-also:
2020
replaces:
2121
stage: stable

0 commit comments

Comments
 (0)