Commit ed6c9ef
committed
config: Explicily make consoleSize unspecified if terminal is false or unset
The old language is from a502caf (config: Add consoleSize to process,
2016-09-14, opencontainers#563), where nobody commented on the "if attached" wording
[1]. But reading the old line now, it's not clear to me what
consoleSize means when terminal is not true.
This commit explicitly declares consoleSize ignored in that condition.
I'd rather have made it unspecified, so runtimes are free to do what
they want short of erroring out, but Michael wanted the more specific
"ignored" [2]. I considered making the property undefined or
requiring it to be unset, but those seemed too strict given our
permissive "MUST ignore unknown properties" extensibility requirement.
[1]: opencontainers#563
[2]: opencontainers#863 (comment)
Signed-off-by: W. Trevor King <[email protected]>1 parent f79b61d commit ed6c9ef
1 file changed
+2
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
| 141 | + | |
141 | 142 | | |
142 | 143 | | |
143 | 144 | | |
| |||
0 commit comments