constants tests

Author: kirjavascript

src/modes/crash.asm

@@ -1,3 +1,5 @@
+; Hydrant's crash theory sheet https://docs.google.com/spreadsheets/d/1zAQIo_mnkk0c9e4-hpeDvVxrl9r_HvLSx8V4h4ttmrs/edit#gid=1013692687
+
 testCrash:
         lda #$1C ; setting all cycles which always happen. for optimizing, this can be removed if all compared numbers are reduced by $6F1C.
         sta cycleCount

src/nmi/render_util.asm

@@ -66,7 +66,7 @@ vramPlayfieldRows:
         .word   $22CC,$22EC,$230C,$232C
 
 copyLowStackRowToVram:
-        lda lowStackRow
+        lda lowStackRowModifier
         asl
         tax
         lda vramPlayfieldRows+1,x

src/playstate/lock.asm

@@ -85,7 +85,7 @@ playState_lockTetrimino:
         bcc @notAboveLowStack
         ldx #<lowStackNopeGraphic
         ldy #>lowStackNopeGraphic
-        lda lowStackRow
+        lda lowStackRowModifier
         cmp #$09
         bcs @drawOnUpperHalf
 ; draw on lower half

src/playstate/util.asm

@@ -116,7 +116,7 @@ updateMusicSpeed:
 
 checkIfAboveLowStackLine:
 ; carry set - block found
-        ldx lowStackRow
+        ldx lowStackRowModifier
         lda multBy10Table,x
         tay
         ldx #$0A

src/ram.asm

@@ -339,7 +339,7 @@ checkerModifier: .res 1
 garbageModifier: .res 1
 droughtModifier: .res 1
 dasModifier: .res 1
-lowStackRow: .res 1
+lowStackRowModifier: .res 1
 scoringModifier: .res 1
 crashModifier: .res 1
 strictFlag: .res 1 ;used for crash detection. If 1, the game will register a crash anytime there is a possibility of one.

tests/src/constants.rs

@@ -0,0 +1,23 @@
+use crate::{labels, util};
+
+pub fn test() {
+    // check some hardcoded ram addresses are aligned
+    assert_eq!(labels::get("stack"), 0x100);
+    assert_eq!(labels::get("playfield"), 0x400);
+    assert_eq!(labels::get("highscores"), 0x700);
+    assert_eq!(labels::get("menuRAM"), 0x760);
+
+    // check the right amount of menu ram exists
+    let qty = labels::get("MODE_QUANTITY") as usize;
+    let cfg = labels::get("menuConfigSizeLookup") as usize;
+
+    let mut menu_options = 0;
+
+    for i in 0..qty {
+        if util::rom_data()[cfg + i - 0x8000] != 0 {
+            menu_options += 1;
+        }
+    }
+
+    assert_eq!(menu_options, labels::get("palFlag") + 1 - labels::get("menuVars"));
+}

tests/src/main.rs

@@ -18,6 +18,7 @@ mod toprow;
 mod tspins;
 mod hz_display;
 mod nmi;
+mod constants;
 
 use gumdrop::Options;
 
@@ -48,7 +49,7 @@ struct TestOptions {
 fn main() {
     let options = TestOptions::parse_args_default_or_exit();
 
-    let tests: [(&str, fn()); 12] = [
+    let tests: [(&str, fn()); 13] = [
         ("garbage4", garbage::test_garbage4_crash),
         ("floor", floor::test),
         ("tspins", tspins::test),
@@ -61,6 +62,7 @@ fn main() {
         ("palettes", palettes::test),
         ("hz_display", hz_display::test),
         ("nmi", nmi::test),
+        ("constants", constants::test),
     ];
 
     // run tests

tests/src/ram.rs

@@ -0,0 +1,11 @@
+use crate::labels;
+
+pub fn test() {
+    // check some hardcoded ram addresses are aligned
+    assert_eq!(labels::get("stack"), 0x100);
+    assert_eq!(labels::get("playfield"), 0x400);
+    assert_eq!(labels::get("highscores"), 0x700);
+    assert_eq!(labels::get("menuRAM"), 0x760);
+
+    println!("{:x}", labels::get("LINECAP_HOW_STRING_OFFSET"));
+}

tests/src/util.rs

@@ -2,8 +2,14 @@ use rusticnes_core::nes::NesState;
 use rusticnes_core::{ cartridge, opcodes, opcode_info };
 use crate::{input, labels};
 
+static ROM: &'static [u8] = include_bytes!("../../tetris.nes");
+
+pub fn rom_data() -> &'static [u8] {
+    &ROM[0x10..]
+}
+
 pub fn emulator(rom: Option<&[u8]>) -> NesState {
-    let rom = rom.unwrap_or(include_bytes!("../../tetris.nes"));
+    let rom = rom.unwrap_or(ROM);
     let mut emu = NesState::new(Box::new(cartridge::mapper_from_file(rom)).unwrap());
 
     emu.power_on();