Skip to content

Commit bf9a4c4

Browse files
authored
Merge pull request #127 from kit-data-manager/improved-design
Minor design optimizations
2 parents 749cb17 + 053897c commit bf9a4c4

File tree

8 files changed

+21
-14
lines changed

8 files changed

+21
-14
lines changed

.pre-commit-config.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,15 @@ repos:
44
- repo: https://github.com/pre-commit/pre-commit-hooks
55
rev: v3.2.0
66
hooks:
7-
- id: trailing-whitespace
87
- id: check-yaml
98
- id: check-added-large-files
109
- repo: https://github.com/Materials-Data-Science-and-Informatics/somesy
1110
rev: "v0.7.3"
1211
hooks:
1312
- id: somesy
13+
- repo: local
14+
hooks:
15+
- id: eslint
16+
name: ESLint
17+
entry: npm run lint
18+
language: node

CITATION.cff

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ title: '@kit-data-manager/mapping-service-input'
55
abstract: The mapping-service-input provides a minimalistic user interface for
66
the KIT Data Manager Mapping Service. It allows users to select an existing
77
mapping schema and use it to map their data.
8-
version: 1.2.2
8+
version: 1.2.3
99
keywords:
1010
- metadata
1111
- JSON

codemeta.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
],
2929
"name": "@kit-data-manager/mapping-service-input",
3030
"description": "The mapping-service-input provides a minimalistic user interface for the KIT Data Manager Mapping Service. It allows users to select an existing mapping schema and use it to map their data.",
31-
"version": "1.2.2",
31+
"version": "1.2.3",
3232
"keywords": [
3333
"metadata",
3434
"JSON",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"url": "https://orcid.org/0000-0003-2804-688X"
77
},
88
"license": "Apache-2.0",
9-
"version": "1.2.2",
9+
"version": "1.2.3",
1010
"private": false,
1111
"keywords": [
1212
"metadata",

somesy.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "@kit-data-manager/mapping-service-input"
3-
version = "1.2.2"
3+
version = "1.2.3"
44
description = "The mapping-service-input provides a minimalistic user interface for the KIT Data Manager Mapping Service. It allows users to select an existing mapping schema and use it to map their data."
55
license = "Apache-2.0"
66
repository = "https://github.com/kit-data-manager/com_mapping-service-input.git"

src/main.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,7 @@ class MappingInputProvider extends HTMLElement {
452452
const buttons = this.shadowRoot.querySelectorAll<HTMLButtonElement>('.selection-button');
453453
buttons.forEach((b) => {
454454
b.classList.remove('selected-id');
455+
b.textContent = 'Select';
455456
b.setAttribute('aria-selected', 'false');
456457
});
457458
if (id && id !== this.selectedMappingId && id !== '') {

src/style.css

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,16 @@ button[disabled|='true'] {
9999
color: var(--text-white);
100100
width: 100%;
101101
flex: 1 0 auto;
102+
align-items: center;
102103
justify-content: center;
104+
padding: 0.375rem;
103105
}
104106

105107
.title {
106108
font-size: large;
107109
font-weight: bold;
108-
display: flex;
109-
margin: 0.375rem;
110-
flex: 1 0 calc(var(--grid-element-min-width) - 2*0.4rem);
111-
line-break: auto;
110+
display: inline-flex;
111+
flex: 1 0 calc(var(--grid-element-min-width) - 2 * 0.4rem);
112112
align-items: center; /* Vertical centering */
113113
justify-content: center; /* Horizontal centering */
114114
height: 100%; /* Ensure the div has height */
@@ -167,11 +167,12 @@ button[disabled|='true'] {
167167
.description {
168168
/*flex: 0 1 auto;*/
169169
color: var(--deactivated-color) !important;
170-
padding: 0.5rem;
170+
font-size: medium;
171+
padding-inline: 0.5rem;
171172
display: inline-block;
172173
text-align: justify;
173174
overflow-x: auto;
174-
height: calc(var(--grid-element-min-width)/2 + 2rem);
175+
height: calc(var(--grid-element-min-width) / 2 + 2rem);
175176
margin-bottom: var(--margin-around);
176177
}
177178

@@ -193,8 +194,8 @@ button[disabled|='true'] {
193194
grid-template-columns: 1fr;
194195
}
195196

196-
.description{
197-
height: calc((var(--grid-element-min-width)*2)/3 + 1rem);
197+
.description {
198+
height: calc((var(--grid-element-min-width) * 2) / 3 + 1rem);
198199
}
199200
}
200201

@@ -234,6 +235,7 @@ button[disabled|='true'] {
234235

235236
&:has(> button.selected-id) {
236237
outline: 0.3rem solid var(--tertiary-color);
238+
border: 1px solid var(--tertiary-color);
237239

238240
.header {
239241
background-color: var(--tertiary-color) !important;

src/template.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<div class="step" id="step-1" role="tab">
22
<h3 aria-hidden="true">Select a Mapping</h3>
3-
43
<div id="options" class="mapping-options" role="tablist" aria-description="Select one of the available mappings">
54
<div class="container-wrapper">
65
<div

0 commit comments

Comments
 (0)