make catch all controller obsolete in favor of a static index page on the root path.

GGoetzelmann · GGoetzelmann · commit fc7be419243c · 2025-06-17T14:32:21.000+02:00
diff --git a/src/main/java/edu/kit/scc/dem/wapsrv/controller/CatchAllController.java b/src/main/java/edu/kit/scc/dem/wapsrv/controller/CatchAllController.java
@@ -5,6 +5,8 @@
 import jakarta.servlet.http.HttpServletRequest;
 import org.eclipse.jetty.http.HttpMethod;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.context.annotation.Bean;
+import org.springframework.core.io.ClassPathResource;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
@@ -18,6 +20,11 @@
 import edu.kit.scc.dem.wapsrv.exceptions.InvalidRequestException;
 import edu.kit.scc.dem.wapsrv.exceptions.MethodNotAllowedException;
 import edu.kit.scc.dem.wapsrv.exceptions.WapException;
+import org.springframework.web.servlet.function.RouterFunction;
+import org.springframework.web.servlet.function.ServerResponse;
+
+import static org.springframework.web.servlet.function.RequestPredicates.path;
+import static org.springframework.web.servlet.function.RouterFunctions.route;
 
 /**
  * This controller adds the catch all feature to the server which answers all request that not mapped correctly
@@ -30,15 +37,20 @@
  * @version 1.1
  */
 @RestController
-@RequestMapping("/")
 public class CatchAllController extends BasicController {
    @Autowired
    private WapServerConfig wapServerConfig;
 
+   @Bean
+   RouterFunction<ServerResponse> spaRouter() {
+      ClassPathResource index = new ClassPathResource("static/index.html");
+      return route().resource(path("/"), index).build();
+   }
+
    /**
     * This method implements the endpoint that catches all otherwise not mapped requests to create meaningful error
     * messages
-    * 
+    *
     * @param  request
     *                      The request the client sent
     * @param  headers
@@ -47,9 +59,10 @@ public class CatchAllController extends BasicController {
     * @throws WapException
     *                      in case any error occurs
     */
-   @RequestMapping(value = { "/", "/{path:[^\\.]*}" })
+
    public ResponseEntity<?> catchallRequest(HttpServletRequest request, @RequestHeader HttpHeaders headers)
          throws WapException {
+      //TODO: should be obsolete, currently here for sake of existing tests
       // The basic idea is that all "real" controllers just intercept those messages
       // that truly fit them and check their parameters, headers and so on there.
       // All request that do not exactly fit one request and cannot be mapped, land here
diff --git a/src/test/java/edu/kit/scc/dem/wapsrv/testsrest/AnnotationRestTest.java b/src/test/java/edu/kit/scc/dem/wapsrv/testsrest/AnnotationRestTest.java
@@ -795,7 +795,7 @@ public void testPutAnnotationWithParams() {
         // The annotation does not have to exist for this test
         String containerIri = createDefaultContainer(null); // in the root container
         try {
-            URL url = new URL(containerIri);
+            URL url = new URL(containerIri + "anno1");
             String params = "test=1";
             Map<String, Object> requestHeaders = new Hashtable<String, Object>();
             requestHeaders.put("Content-Type", "application/ld+json;profile=\"http://www.w3.org/ns/anno.jsonld\"");
@@ -805,7 +805,7 @@ public void testPutAnnotationWithParams() {
                     = performOwnHttpRequest(url, OwnHttpURLConnection.Request.PUT, requestHeaders, params, annotation);
             // logger.trace(response.getTransmittedString());
             // logger.trace(response.getReceivedString());
-            checkException(IllegalHttpParameterException.class, response, ErrorMessageRegistry.ALL_NO_PARAMETERS_IN_PUT);
+            checkException(IllegalHttpParameterException.class, response, "No parameters allowed");
         } catch (MalformedURLException e) {
             fail(e.getMessage());
         }
diff --git a/static/index.html b/static/index.html
@@ -0,0 +1,6 @@
+<html>
+A GET request to the server's base url has been received. To interact with this server, there are a few endpoint you can send requests to :<br>
+<ul><li><a href="./wap/">./wap/</a> for requests to the main functinality, the Web Annotation Protocol Service</li>
+    <li><a href="./webapp">./webapp</a> for requests to the Web Annotation Protocol Service Client</li>
+    <li><a href="./javadoc">./javadoc</a> for requests to the the integrated javadoc</li>
+</ul></html>
