#6 - fmt + clippy integration

- update version & release notes
- remove rating dialog & integrate with release notes

Author: parthopdas

src/RustAnalyzer.TestAdapter/Constants.cs

@@ -5,10 +5,11 @@ namespace KS.RustAnalyzer.TestAdapter;
 
 public static class Constants
 {
-    public const string ReleaseSummary = $"Significant refactoring of the {ManifestFileName} parser module resulting in simpler code & robust handling of various crates and workspaces scenarios. Please report any issues you face.";
+    public const string ReleaseSummary = $"Right click on {ManifestFileName} to run clippy / fmt, use Tools > Options to change defaults. Please report any issues you face. Consider giving 5⭐ if you find this extension useful.";
     public const string ReleaseNotesUrl = $"https://github.com/kitamstudios/rust-analyzer.vs/releases/{Vsix.Version}";
     public const string DiscordUrl = "https://discord.gg/JyK55EsACr";
     public const string PrerequisitesUrl = "https://github.com/kitamstudios/rust-analyzer.vs/blob/master/PREREQUISITES.md";
+    public const string RateExtensionUrl = "https://marketplace.visualstudio.com/items?itemName=kitamstudios.RustAnalyzer&ssr=false#review-details";
 
     public const string RustLanguageContentType = "rust";
     public const string RustFileExtension = ".rs";

src/RustAnalyzer/Infrastructure/Options.cs

@@ -12,7 +12,7 @@ public class GeneralOptions : BaseOptionPage<Options>
     }
 }
 
-public class Options : BaseOptionModel<Options>, IRatingConfig
+public class Options : BaseOptionModel<Options>
 {
     [DisplayName("Default Clippy Arguments")]
     [Description("Command line arguments passed to cargo clippy. Default is: --all-targets --all-features -- -D warnings")]
@@ -21,7 +21,4 @@ public class Options : BaseOptionModel<Options>, IRatingConfig
     [DisplayName("Default Cargo Arguments")]
     [Description("Command line arguments passed to cargo fmt. Default is: --all")]
     public string DefailtCargoFmtArgs { get; set; } = "--all";
-
-    [Browsable(false)]
-    public int RatingRequests { get; set; }
 }

src/RustAnalyzer/RustAnalyzer.csproj

@@ -136,7 +136,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Community.VisualStudio.VSCT" Version="16.0.29.6" PrivateAssets="all" />
-    <PackageReference Include="Community.VisualStudio.Toolkit.17" Version="17.0.492" ExcludeAssets="Runtime" />
+    <PackageReference Include="Community.VisualStudio.Toolkit.17" Version="17.0.430" ExcludeAssets="Runtime" />
     <PackageReference Include="Microsoft.ApplicationInsights">
       <Version>2.21.0</Version>
     </PackageReference>
@@ -146,7 +146,7 @@
     <PackageReference Include="Microsoft.VisualStudio.TestWindow.Interfaces">
       <Version>11.0.61030</Version>
     </PackageReference>
-    <PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.5.4065" />
+    <PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.0.5232" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.4.33103.184" ExcludeAssets="runtime">
@@ -174,6 +174,10 @@
       <Version>17.1.11-preview-0002</Version>
       <NoWarn>NU1603</NoWarn>
     </PackageReference>
+    <PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.1.4057">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\RustAnalyzer.TestAdapter\RustAnalyzer.TestAdapter.csproj">

src/RustAnalyzer/RustAnalyzerPackage.cs

@@ -38,16 +38,13 @@ public sealed class RustAnalyzerPackage : ToolkitPackage
 {
     private TL _tl;
     private IPreReqsCheckService _preReqs;
-    private RatingPrompt _ratingPrompt;
 
     protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress)
     {
         await this.RegisterCommandsAsync();
 
         await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken);
 
-        _ratingPrompt = new RatingPrompt("kitamstudios.RustAnalyzer", Vsix.Name, Options.Instance);
-
         var cmServiceProvider = (IComponentModel)await GetServiceAsync(typeof(SComponentModel));
         _tl = new TL
         {
@@ -66,8 +63,6 @@ protected override async Task OnAfterPackageLoadedAsync(CancellationToken cancel
         await ReleaseSummaryNotification.ShowAsync(this, _tl);
         await SearchAndDisableIncompatibleExtensionsAsync();
         await _preReqs.SatisfyAsync();
-
-        _ratingPrompt.RegisterSuccessfulUsage();
     }
 
     #region Handling incompatible extensions
@@ -151,6 +146,7 @@ public static class ReleaseSummaryNotification
         private const string ActionContextReleaseNotes = "release_notes";
         private const string ActionContextDismiss = "dismiss";
         private const string ActionContextGetHelp = "get_help";
+        private const string ActionContextRateExtension = "rate_extension";
         private const string DismissedRegKeyName = "release_notes_dismissed";
 
         public static async Task ShowAsync(IServiceProvider sp, TL tl)
@@ -166,7 +162,7 @@ public static async Task ShowAsync(IServiceProvider sp, TL tl)
 
             var actionItems = new[]
             {
-                new InfoBarHyperlink("Release notes", ActionContextReleaseNotes),
+                new InfoBarHyperlink("Rate Extension", ActionContextRateExtension),
                 new InfoBarHyperlink("Get help!", ActionContextGetHelp),
                 new InfoBarHyperlink("Dismiss", ActionContextDismiss),
             };
@@ -191,8 +187,8 @@ private static void InfoBar_ActionItemClicked(object sender, InfoBarActionItemEv
 
             switch (actionContext)
             {
-                case ActionContextReleaseNotes:
-                    VsShellUtilities.OpenSystemBrowser(Constants.ReleaseNotesUrl);
+                case ActionContextRateExtension:
+                    VsShellUtilities.OpenSystemBrowser(Constants.RateExtensionUrl);
                     break;
 
                 case ActionContextGetHelp:

src/RustAnalyzer/source.extension.cs

@@ -11,7 +11,7 @@ internal sealed partial class Vsix
         public const string Name = "rust-analyzer.vs";
         public const string Description = @"Rust language support for Visual Studio";
         public const string Language = "en-US";
-        public const string Version = "1.6";
+        public const string Version = "1.7";
         public const string Author = "Kitam Studios";
         public const string Tags = "Rust;Cargo;RustAnalyzer";
     }

src/RustAnalyzer/source.extension.vsixmanifest

@@ -3,7 +3,7 @@
   xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011"
   xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
   <Metadata>
-    <Identity Id="KS.RustAnalyzer.3a91e56b-fb28-4d85-b572-ec964abf8e31" Version="1.6" Language="en-US" Publisher="Kitam Studios" />
+    <Identity Id="KS.RustAnalyzer.3a91e56b-fb28-4d85-b572-ec964abf8e31" Version="1.7" Language="en-US" Publisher="Kitam Studios" />
     <DisplayName>rust-analyzer.vs</DisplayName>
     <Description xml:space="preserve">Rust language support for Visual Studio</Description>
     <MoreInfo>https://github.com/kitamstudios/rust-analyzer.vs</MoreInfo>