[release] notify use to restart VS if RLS has been updated.

Author: parthopdas

src/RustAnalyzer.UnitTests/RAExeReleaseTests.cs

@@ -12,10 +12,10 @@ public sealed class RAExeReleaseTests
     [Fact]
     public async Task LastUpdateShouldNotBeOlderThan30DaysAsync()
     {
-        var ret = await RAInstallerService.GetLatestRAReleaseRedirectUriAsync();
+        var ret = await RlsInstallerService.GetLatestRAReleaseRedirectUriAsync();
 
-        var latestRelDate = DateTime.ParseExact(ret?.Version, RAInstallerService.RAVersionFormat, CultureInfo.InvariantCulture);
-        var lastUpdateDate = DateTime.ParseExact(RAInstallerService.LatestInPackageRAVersion, RAInstallerService.RAVersionFormat, CultureInfo.InvariantCulture);
+        var latestRelDate = DateTime.ParseExact(ret?.Version, RlsInstallerService.RAVersionFormat, CultureInfo.InvariantCulture);
+        var lastUpdateDate = DateTime.ParseExact(RlsInstallerService.LatestInPackageRAVersion, RlsInstallerService.RAVersionFormat, CultureInfo.InvariantCulture);
         lastUpdateDate.Should().NotBeBefore(latestRelDate.AddDays(-120), $"new rust-analyzer.exe is available {ret?.Uri}");
     }
 }

src/RustAnalyzer/Editor/BuildFileContext.cs

@@ -49,6 +49,7 @@ public async Task<bool> ExecuteBuildAsync(IBuildActionProgress progress, Cancell
             OutputSink = _outputPane,
         };
 
+        await RlsUpdatedNotification.ShowAsync();
         return await _commandFunc(BuildTargetInfo, bos, cancellationToken);
     }
 }

…zer/Infrastructure/RAInstallerService.cs …er/Infrastructure/RlsInstallerService.cssrc/RustAnalyzer/Infrastructure/RAInstallerService.cs renamed to src/RustAnalyzer/Infrastructure/RlsInstallerService.cs src/RustAnalyzer/Infrastructure/RAInstallerService.cs renamed to src/RustAnalyzer/Infrastructure/RlsInstallerService.cs

@@ -14,16 +14,16 @@
 
 namespace KS.RustAnalyzer.Infrastructure;
 
-public interface IRAInstallerService
+public interface IRlsInstallerService
 {
     Task<PathEx> GetRustAnalyzerExePathAsync();
 
     Task InstallLatestRAAsync();
 }
 
-[Export(typeof(IRAInstallerService))]
+[Export(typeof(IRlsInstallerService))]
 [PartCreationPolicy(CreationPolicy.Shared)]
-public class RAInstallerService : IRAInstallerService
+public class RlsInstallerService : IRlsInstallerService
 {
     public const string LatestInPackageRAVersion = "2024-01-08";
     public const string RAVersionFormat = "yyyy-MM-dd";
@@ -32,7 +32,7 @@ public class RAInstallerService : IRAInstallerService
     private readonly TL _tl;
 
     [ImportingConstructor]
-    public RAInstallerService(IRegistrySettingsService regSettings, [Import] ITelemetryService t, [Import] ILogger l)
+    public RlsInstallerService(IRegistrySettingsService regSettings, [Import] ITelemetryService t, [Import] ILogger l)
     {
         _regSettings = regSettings;
         _tl = new TL
@@ -124,6 +124,7 @@ private async Task CommitAsync((Uri Uri, string Version)? latestRel)
         }
 
         Registry.SetValue(regRoot, InstalledRAVersionKey, latestRel?.Version);
+        RlsUpdatedNotification.Enabled = true;
         _tl.L.WriteLine($"Committed RA installation.");
     }
 

src/RustAnalyzer/Infrastructure/RlsUpdatedNotification.cs

@@ -0,0 +1,56 @@
+using System;
+using System.Threading.Tasks;
+using KS.RustAnalyzer;
+using KS.RustAnalyzer.TestAdapter.Common;
+using Microsoft.VisualStudio.Imaging;
+using Microsoft.VisualStudio.Shell;
+using Microsoft.VisualStudio.Shell.Interop;
+using CommunityVS = Community.VisualStudio.Toolkit.VS;
+
+public static class RlsUpdatedNotification
+{
+    public const string RLSUPDATEDENVVARNAME = "RA.VS_RLS_UPDATED";
+
+    private static int _counter = 0;
+
+    public static bool Enabled
+    {
+        private get
+        {
+            return Environment.GetEnvironmentVariable(RLSUPDATEDENVVARNAME, EnvironmentVariableTarget.Process).IsNullOrEmpty();
+        }
+
+        set
+        {
+            Environment.SetEnvironmentVariable(RLSUPDATEDENVVARNAME, true.ToString(), EnvironmentVariableTarget.Process);
+        }
+    }
+
+    public static async Task ShowAsync()
+    {
+        if (Enabled)
+        {
+            return;
+        }
+
+        if (IsTimeToShowAgain())
+        {
+            return;
+        }
+
+        await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();
+
+        var model = new InfoBarModel(
+            textSpans: new[] { new InfoBarTextSpan($"{Vsix.Name}: Rust Langugage Server was updated in the background. Restart VS to start using the new version. Using the old version may lead to degraded editor experience."), },
+            Array.Empty<IVsInfoBarActionItem>(),
+            image: KnownMonikers.StatusWarning,
+            isCloseButtonVisible: true);
+        var infoBar = await CommunityVS.InfoBar.CreateAsync(model);
+        await infoBar.TryShowInfoBarUIAsync();
+    }
+
+    private static bool IsTimeToShowAgain()
+    {
+        return _counter++ % 10 != 0;
+    }
+}

src/RustAnalyzer/LanguageService/LanguageClient.cs

@@ -37,7 +37,7 @@ public class LanguageClient : ILanguageClient, ILanguageClientCustomMessage2
     public ITelemetryService T { get; set; }
 
     [Import]
-    public IRAInstallerService RADownloader { get; set; }
+    public IRlsInstallerService RADownloader { get; set; }
 
     public JsonRpc Rpc { get; set; }
 

src/RustAnalyzer/RustAnalyzer.csproj

@@ -45,7 +45,8 @@
     <WarningLevel>4</WarningLevel>
   </PropertyGroup>
   <ItemGroup>
-    <Compile Include="Infrastructure\RAInstallerService.cs" />
+    <Compile Include="Infrastructure\RlsInstallerService.cs" />
+    <Compile Include="Infrastructure\RlsUpdatedNotification.cs" />
     <Compile Include="Infrastructure\RegistrySettingsService.cs" />
     <Compile Include="Infrastructure\SettingsInfo.cs" />
     <Compile Include="LanguageService\CommentHelper.cs" />

src/RustAnalyzer/RustAnalyzerPackage.cs

@@ -36,7 +36,7 @@ public sealed class RustAnalyzerPackage : ToolkitPackage
     private TL _tl;
     private IRegistrySettingsService _regSettings;
     private IPreReqsCheckService _preReqs;
-    private IRAInstallerService _raDownloader;
+    private IRlsInstallerService _raDownloader;
 
     protected override async Task InitializeAsync(CancellationToken cancellationToken, IProgress<ServiceProgressData> progress)
     {
@@ -52,7 +52,7 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke
         };
         _regSettings = cmServiceProvider?.GetService<IRegistrySettingsService>();
         _preReqs = cmServiceProvider?.GetService<IPreReqsCheckService>();
-        _raDownloader = cmServiceProvider?.GetService<IRAInstallerService>();
+        _raDownloader = cmServiceProvider?.GetService<IRlsInstallerService>();
     }
 
     protected override async Task OnAfterPackageLoadedAsync(CancellationToken cancellationToken)
@@ -65,6 +65,7 @@ protected override async Task OnAfterPackageLoadedAsync(CancellationToken cancel
         await SearchAndDisableIncompatibleExtensionsAsync();
         await _preReqs.SatisfyAsync();
         await _raDownloader.InstallLatestRAAsync();
+        await RlsUpdatedNotification.ShowAsync();
     }
 
     #region Handling incompatible extensions