Add more missing tests

Author: kitar

src/Kitar/Dynamodb/Connection.php

@@ -3,6 +3,7 @@
 namespace Kitar\Dynamodb;
 
 use Aws\Sdk as AwsSdk;
+use Aws\DynamoDb\DynamoDbClient;
 use Illuminate\Database\Connection as BaseConnection;
 
 class Connection extends BaseConnection
@@ -71,6 +72,16 @@ public function createClient(array $config)
         return $sdk->createDynamoDb();
     }
 
+    /**
+     * Set the DynamoDB client.
+     * @param DynamoDbClient $client
+     * @return void
+     */
+    public function setClient(DynamoDbClient $client)
+    {
+        $this->client = $client;
+    }
+
     /**
      * @inheritdoc
      */

src/Kitar/Dynamodb/Query/Builder.php

@@ -361,6 +361,7 @@ public function where($column, $operator = null, $value = null, $boolean = 'and'
         // assume that the developer is just short-cutting the '=' operators and
         // we will set the operators to '=' and set the values appropriately.
         if ($this->invalidOperator($operator)) {
+            $operator = $this->expression_attributes->addValue($operator);
             [$value, $operator] = [$operator, '='];
         }
 

tests/ConnectionTest.php

@@ -2,20 +2,29 @@
 
 namespace Kitar\Dynamodb\Tests;
 
+use Mockery as m;
 use Kitar\Dynamodb\Connection;
 use Kitar\Dynamodb\Query\Builder;
 use Aws\DynamoDb\DynamoDbClient;
 use PHPUnit\Framework\TestCase;
+use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
 
 class ConnectionTest extends TestCase
 {
+    use MockeryPHPUnitIntegration;
+
     protected $connection;
 
     protected function setUp() :void
     {
         $this->connection = new Connection([]);
     }
 
+    protected function tearDown() :void
+    {
+        m::close();
+    }
+
     /** @test */
     public function it_creates_connection()
     {
@@ -57,4 +66,34 @@ public function it_returns_query_builder_instance()
 
         $this->assertEquals('test', $query->from);
     }
+
+    /** @test */
+    public function it_can_call_client_query()
+    {
+        $client = m::mock(DynamoDbClient::class);
+        $client->shouldReceive('query')->with([
+            'TableName' => 'User'
+        ]);
+
+        $connection = new Connection([]);
+        $connection->setClient($client);
+        $connection->clientQuery([
+            'TableName' => 'User'
+        ]);
+    }
+
+    /** @test */
+    public function it_can_forward_call_to_dynamodb_client()
+    {
+        $client = m::mock(DynamoDbClient::class);
+        $client->shouldReceive('getItem')->with([
+            'TableName' => 'User'
+        ]);
+
+        $connection = new Connection([]);
+        $connection->setClient($client);
+        $connection->getItem([
+            'TableName' => 'User'
+        ]);
+    }
 }

tests/Helpers/NumberIteratorTest.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace Kitar\Dynamodb\Tests;
+
+use Kitar\Dynamodb\Helpers\NumberIterator;
+use PHPUnit\Framework\TestCase;
+
+class NumberIteratorTest extends TestCase
+{
+    /** @test */
+    public function it_can_use_prefix()
+    {
+        $iterator = new NumberIterator(1, '#');
+
+        $this->assertEquals('#1', $iterator->current());
+    }
+
+    /** @test */
+    public function it_can_increment()
+    {
+        $iterator = new NumberIterator(1, ':');
+
+        $iterator->next();
+
+        $this->assertEquals(':2', $iterator->current());
+
+        $iterator->next();
+
+        $this->assertEquals(':3', $iterator->current());
+    }
+
+    /** @test */
+    public function key_returns_number_without_prefix()
+    {
+        $iterator = new NumberIterator(1, '#');
+
+        $iterator->next();
+
+        $this->assertEquals(2, $iterator->key());
+    }
+
+    /** @test */
+    public function it_can_rewind()
+    {
+        $iterator = new NumberIterator(1, '#');
+
+        $iterator->next();
+        $iterator->next();
+        $iterator->next();
+        $iterator->rewind();
+
+        $this->assertEquals('#1', $iterator->current());
+    }
+
+    /** @test */
+    public function it_is_always_valid()
+    {
+        $iterator = new NumberIterator(1);
+
+        $this->assertTrue($iterator->valid());
+    }
+}

tests/Query/BuilderTest.php

@@ -3,6 +3,7 @@
 namespace Kitar\Dynamodb\Tests\Query;
 
 use Aws\Result;
+use BadMethodCallException;
 use Mockery as m;
 use Kitar\Dynamodb\Connection;
 use Kitar\Dynamodb\Model\Model;
@@ -179,6 +180,28 @@ public function it_can_process_filter()
         $this->assertEquals($params, $query['params']);
     }
 
+    /** @test */
+    public function it_can_process_filter_with_short_syntax()
+    {
+        $params = [
+            'TableName' => 'Thread',
+            'FilterExpression' => '#1 = :1',
+            'ExpressionAttributeNames' => [
+                '#1' => 'ForumName'
+            ],
+            'ExpressionAttributeValues' => [
+                ':1' => [
+                    'S' => 'Amazon DynamoDB'
+                ]
+            ]
+        ];
+        $query = $this->newQuery('Thread')
+                      ->filter('ForumName', 'Amazon DynamoDB')
+                      ->scan();
+
+        $this->assertEquals($params, $query['params']);
+    }
+
     /** @test */
     public function it_can_process_condition()
     {
@@ -780,4 +803,14 @@ public function it_can_process_process_with_no_processor()
             'Subject' => 'Laravel Thread 1'
         ]);
     }
+
+    /** @test */
+    public function it_can_forward_call_to_unknown_method()
+    {
+        $query = $this->newQuery('Thread');
+
+        $this->expectException(BadMethodCallException::class);
+
+        $query->filterNotIn(['foo', 'bar']);
+    }
 }