Skip to content
This repository was archived by the owner on Jun 17, 2018. It is now read-only.

Commit ba11e66

Browse files
authored
Merge pull request #320 from kitasuke/fix_didScrollEnd_event
Fix didScrollEnd event
2 parents a0ef2e9 + 8f1a786 commit ba11e66

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Example/PagingMenuControllerDemo2/RootViewControoler.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ class RootViewControoler: UIViewController {
6666
case let .didMoveItem(menuItemView, previousMenuItemView):
6767
print(previousMenuItemView)
6868
print(menuItemView)
69+
case .didScrollStart:
70+
print("Scroll start")
71+
case .didScrollEnd:
72+
print("Scroll end")
6973
}
7074
}
7175

Pod/Classes/PagingMenuController.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,8 @@ open class PagingMenuController: UIViewController {
312312

313313
extension PagingMenuController: UIScrollViewDelegate {
314314
public func scrollViewDidEndDecelerating(_ scrollView: UIScrollView) {
315+
onMove?(.didScrollEnd)
316+
315317
let nextPage: Int
316318
switch (scrollView, pagingViewController, menuView) {
317319
case let (scrollView, pagingViewController?, _) where scrollView.isEqual(pagingViewController.contentScrollView):
@@ -327,11 +329,7 @@ extension PagingMenuController: UIScrollViewDelegate {
327329
public func scrollViewWillBeginDragging(_ scrollView: UIScrollView) {
328330
onMove?(.didScrollStart)
329331
}
330-
331-
public func scrollViewDidEndDecelerating(_ scrollView: UIScrollView, willDecelerate decelerate: Bool) {
332-
onMove?(.didScrollEnd)
333-
}
334-
332+
335333
public func scrollViewDidEndDragging(_ scrollView: UIScrollView, willDecelerate decelerate: Bool) {
336334
switch (scrollView, decelerate) {
337335
case (let scrollView, false) where scrollView.isEqual(menuView): break

0 commit comments

Comments
 (0)