Increate test coverage.

Author: ericof

tests/behaviors/conftest.py

@@ -0,0 +1,83 @@
+from plone.app.testing import setRoles
+from plone.app.testing import SITE_OWNER_NAME
+from plone.app.testing import SITE_OWNER_PASSWORD
+from plone.app.testing import TEST_USER_ID
+from plone.dexterity.fti import DexterityFTI
+from plone.restapi.testing import RelativeSession
+from zope.component.hooks import setSite
+
+import pytest
+import transaction
+
+
+@pytest.fixture()
+def request_factory(portal):
+    def factory(mimetype: str = "application/json") -> RelativeSession:
+        url = portal.absolute_url()
+        api_session = RelativeSession(url)
+        api_session.headers.update({"Accept": mimetype})
+        return api_session
+
+    return factory
+
+
+@pytest.fixture()
+def anon_request(request_factory) -> RelativeSession:
+    return request_factory()
+
+
+@pytest.fixture()
+def manager_request(request_factory):
+    request = request_factory()
+    request.auth = (SITE_OWNER_NAME, SITE_OWNER_PASSWORD)
+    yield request
+    request.auth = ()
+
+
+@pytest.fixture()
+def manager_html_request(request_factory):
+    request = request_factory("text/html")
+    request.auth = (SITE_OWNER_NAME, SITE_OWNER_PASSWORD)
+    yield request
+    request.auth = ()
+
+
+@pytest.fixture
+def portal(functional):
+    return functional["portal"]
+
+
+@pytest.fixture
+def portal_factory(functional):
+    def func(behavior: str):
+        portal = functional["portal"]
+        setRoles(portal, TEST_USER_ID, ["Manager"])
+        fti = DexterityFTI("DummyType")
+        fti.behaviors = (behavior,)
+        portal.portal_types._setObject("DummyType", fti)
+        setSite(portal)
+        transaction.commit()
+        return portal
+
+    return func
+
+
+@pytest.fixture
+def dummy_type_schema(manager_request):
+    def func():
+        url = "/@types/DummyType"
+        response = manager_request.get(url)
+        data = response.json()
+        return data
+
+    return func
+
+
+@pytest.fixture
+def create_dummy_content(manager_request):
+    def func(payload: dict):
+        payload["@type"] = "DummyType"
+        response = manager_request.post("/", json=payload)
+        return response
+
+    return func

tests/behaviors/test_behavior.py

@@ -1,49 +1,57 @@
-def test_seo_behavior_fields(manager_plone_client):
-    # Enable behavior for pages
-    manager_plone_client.patch(
-        "++api++/@controlpanels/dexterity-types/Document",
-        json={"kitconcept.seo": True},
-    )
-
-    # Check schema
-    schema = manager_plone_client.get("++api++/@types/Document").json()
-    assert schema["fieldsets"][-1] == {
-        "behavior": "plone",
-        "description": "",
-        "fields": [
-            "seo_title",
-            "seo_description",
-            "seo_noindex",
-            "seo_canonical_url",
-            "opengraph_title",
-            "opengraph_description",
-            "opengraph_image",
-        ],
-        "id": "seo",
-        "title": "SEO",
-    }
-
-
-def test_noindex_sets_response_header(manager_plone_client):
-    # Enable behavior for pages
-    manager_plone_client.patch(
-        "++api++/@controlpanels/dexterity-types/Document",
-        json={"kitconcept.seo": True},
-    )
-
-    # Add page
-    resp = manager_plone_client.post(
-        "++api++/",
-        json={"@type": "Document", "title": "Test page", "seo_noindex": True},
-    )
-    assert resp.status_code == 201
-
-    # Confirm the page is served with X-Robots-Tag header
-    resp = manager_plone_client.get("/test-page")
-    assert resp.status_code == 200
-    assert resp.headers["X-Robots-Tag"] == "noindex"
-
-    # Confirm views of the page are served with X-Robots-Tag header
-    resp = manager_plone_client.get("/test-page/@@view")
-    assert resp.status_code == 200
-    assert resp.headers["X-Robots-Tag"] == "noindex"
+from copy import deepcopy
+from kitconcept.seo import PACKAGE_NAME
+
+import pytest
+
+
+PAYLOAD = {
+    "seo_title": "Foo Bar",
+    "seo_description": "Lorem ipsum dolor sit amet",
+    "seo_noindex": False,
+    "seo_canonical_url": "https://example.com/canonical-url",
+    "opengraph_title": "Open Graph Title",
+    "opengraph_description": "Open Graph Description",
+    "opengraph_image": None,
+}
+
+
+@pytest.fixture
+def payload() -> dict:
+    data = deepcopy(PAYLOAD)
+    return data
+
+
+class TestBehaviorContato:
+    name: str = f"{PACKAGE_NAME}"
+
+    @pytest.fixture(autouse=True)
+    def _setup(self, portal_factory, dummy_type_schema, manager_html_request):
+        self.portal = portal_factory(behavior=self.name)
+        self.schema = dummy_type_schema()
+        self.request = manager_html_request
+
+    @pytest.mark.parametrize("key", PAYLOAD.keys())
+    def test_behavior_schema(self, key: str):
+        assert key in self.schema["properties"]
+
+    def test_behavior_data(self, payload: dict, create_dummy_content):
+        response = create_dummy_content(payload)
+        assert response.status_code == 201
+
+    def test_noindex_sets_response_header(self):
+        # Add page
+        resp = self.request.post(
+            "++api++/",
+            json={"@type": "DummyType", "title": "Test page", "seo_noindex": True},
+        )
+        assert resp.status_code == 201
+
+        # Confirm the page is served with X-Robots-Tag header
+        resp = self.request.get("/test-page")
+        assert resp.status_code == 200
+        assert resp.headers["X-Robots-Tag"] == "noindex"
+
+        # Confirm views of the page are served with X-Robots-Tag header
+        resp = self.request.get("/test-page/@@view")
+        assert resp.status_code == 200
+        assert resp.headers["X-Robots-Tag"] == "noindex"

tests/conftest.py

@@ -1,12 +1,7 @@
 from kitconcept.seo.testing import FUNCTIONAL_TESTING
 from kitconcept.seo.testing import INTEGRATION_TESTING
-from plone.app.testing import SITE_OWNER_NAME
-from plone.app.testing import SITE_OWNER_PASSWORD
-from plone.restapi.testing import RelativeSession
 from pytest_plone import fixtures_factory
 
-import pytest
-
 
 pytest_plugins = ["pytest_plone"]
 
@@ -17,11 +12,3 @@
         (INTEGRATION_TESTING, "integration"),
     ))
 )
-
-
-@pytest.fixture
-def manager_plone_client(functional):
-    portal = functional["portal"]
-    api_session = RelativeSession(f"{portal.absolute_url()}")
-    api_session.auth = (SITE_OWNER_NAME, SITE_OWNER_PASSWORD)
-    return api_session