[BUGFIX] Parsing timecode in TableOfContent Chapter-Links for A/V Media Files (#1673)

fschoelzel · sebastian-meyer · web-flow · commit 0578d00d62c7 · 2025-07-31T10:59:01.000+02:00
Co-authored-by: Sebastian Meyer &lt;sebastian.meyer@opencultureconsulting.com&gt;
diff --git a/Resources/Private/JavaScript/SlubMediaPlayer/SlubMediaPlayer.js b/Resources/Private/JavaScript/SlubMediaPlayer/SlubMediaPlayer.js
@@ -253,8 +253,10 @@ export default class SlubMediaPlayer extends DlfMediaPlayer {
       }
     }
 
-    // Attempt: Parse timecode hash in URL ("#timecode=120;fileId=FILE_0000_DEFAULT_MPD,FILE_0000_DEFAULT_HLS")
-    const timecodeMatch = link.hash.match(/timecode=(\d+(?:\.\d?)?)(?:;fileIds=([a-zA-Z0-9_,]+))?/);
+    // Attempt: Parse timecode hash in URL. Accepts URLs with hashes like:
+    // #timecode=120;fileIds=FILE_0000_DEFAULT_MPD,FILE_0000_DEFAULT_HLS
+    // #timecode=123.456;fileIds=uuid-0aabcd1e-12a3-xxx,uuid-0aabcd1e-12a3-yyy
+    const timecodeMatch = link.hash.match(/#timecode=(\d+(?:\.\d+)?)(?:;fileIds=([\w,-]+))?/);
     if (timecodeMatch !== null) {
       const timecode = Number(timecodeMatch[1]);
       if (Number.isFinite(timecode)) {

Original file line number	Diff line number	Diff line change
`@@ -253,8 +253,10 @@ export default class SlubMediaPlayer extends DlfMediaPlayer {`
`253`	`253`	`}`
`254`	`254`	`}`
`255`	`255`
`256`		`- // Attempt: Parse timecode hash in URL ("#timecode=120;fileId=FILE_0000_DEFAULT_MPD,FILE_0000_DEFAULT_HLS")`
`257`		`- const timecodeMatch = link.hash.match(/timecode=(\d+(?:\.\d?)?)(?:;fileIds=([a-zA-Z0-9_,]+))?/);`
	`256`	`+ // Attempt: Parse timecode hash in URL. Accepts URLs with hashes like:`
	`257`	`+ // #timecode=120;fileIds=FILE_0000_DEFAULT_MPD,FILE_0000_DEFAULT_HLS`
	`258`	`+ // #timecode=123.456;fileIds=uuid-0aabcd1e-12a3-xxx,uuid-0aabcd1e-12a3-yyy`
	`259`	`+ const timecodeMatch = link.hash.match(/#timecode=(\d+(?:\.\d+)?)(?:;fileIds=([\w,-]+))?/);`
`258`	`260`	`if (timecodeMatch !== null) {`
`259`	`261`	`const timecode = Number(timecodeMatch[1]);`
`260`	`262`	`if (Number.isFinite(timecode)) {`