[BUGFIX] Move css class to li element and fix name for parent container (#1884)

beatrycze-volk · sebastian-meyer · web-flow · commit 6d691d571626 · 2026-03-20T15:17:36.000+01:00
Co-authored-by: Sebastian Meyer &lt;sebastian.meyer@opencultureconsulting.com&gt;
diff --git a/Classes/Controller/ToolboxController.php b/Classes/Controller/ToolboxController.php
@@ -410,7 +410,7 @@ private function getFile(int $page, array $fileGrps): array
     private function renderImageManipulationTool(): void
     {
         // Set parent element for initialization.
-        $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-imagemanipulationtool';
+        $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-tools-imagemanipulation';
 
         $this->view->assign('imageManipulation', true);
         $this->view->assign('parentContainer', $parentContainer);
diff --git a/Resources/Private/Partials/Toolbox/ImageManipulationTool.html b/Resources/Private/Partials/Toolbox/ImageManipulationTool.html
@@ -12,8 +12,8 @@
 <html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers"
       data-namespace-typo3-fluid="true">
 
-<li>
-    <span class="tx-dlf-tools-imagemanipulation" id="tx-dlf-tools-imagemanipulation" data-dic="imagemanipulation-on:{f:translate(key: 'tools.imagemanipulation.on')};imagemanipulation-off:{f:translate(key: 'tools.imagemanipulation.off')};reset:{f:translate(key: 'tools.imagemanipulation.reset')};saturation:{f:translate(key: 'tools.imagemanipulation.saturation')};hue:{f:translate(key: 'tools.imagemanipulation.hue')};contrast:{f:translate(key: 'tools.imagemanipulation.contrast')};brightness:{f:translate(key: 'tools.imagemanipulation.brightness')};invert:{f:translate(key: 'tools.imagemanipulation.invert')};parentContainer:{parentContainer}" title="{f:translate(key: 'tools.imagemanipulation.no-support')}">
+<li class="tx-dlf-tools-imagemanipulation">
+    <span id="tx-dlf-tools-imagemanipulation" data-dic="imagemanipulation-on:{f:translate(key: 'tools.imagemanipulation.on')};imagemanipulation-off:{f:translate(key: 'tools.imagemanipulation.off')};reset:{f:translate(key: 'tools.imagemanipulation.reset')};saturation:{f:translate(key: 'tools.imagemanipulation.saturation')};hue:{f:translate(key: 'tools.imagemanipulation.hue')};contrast:{f:translate(key: 'tools.imagemanipulation.contrast')};brightness:{f:translate(key: 'tools.imagemanipulation.brightness')};invert:{f:translate(key: 'tools.imagemanipulation.invert')};parentContainer:{parentContainer}" title="{f:translate(key: 'tools.imagemanipulation.no-support')}">
     </span>
 </li>
 

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ private function getFile(int $page, array $fileGrps): array`
`410`	`410`	`private function renderImageManipulationTool(): void`
`411`	`411`	`{`
`412`	`412`	`// Set parent element for initialization.`
`413`		`- $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-imagemanipulationtool';`
	`413`	`+ $parentContainer = !empty($this->settings['parentContainer']) ? $this->settings['parentContainer'] : '.tx-dlf-tools-imagemanipulation';`
`414`	`414`
`415`	`415`	`$this->view->assign('imageManipulation', true);`
`416`	`416`	`$this->view->assign('parentContainer', $parentContainer);`