[BUG] Namespace for `DOMXPath` missing in MetsDocument

[BFallert]

Description

When I want to save a document in Typo3 BE, I get several error messages. The error message occurs both when I want to save the data record without or with changes.

Each of the two lines is repeated x times:

12 times:
PHP Warning
Core: Error handler (BE): PHP Warning: DOMXPath::evaluate(): Undefined namespace prefix in /var/www/typo3/packages/bfallert/presentation/Classes/Common/MetsDocument.php line 797

6 time:
PHP Warning
Core: Error handler (BE): PHP Warning: DOMXPath::evaluate(): Undefined namespace prefix in /var/www/typo3/packages/bfallert/presentation/Classes/Common/MetsDocument.php line 850

Reproduction

Steps to reproduce the behaviour:

1. Open Typo3-BE
2. Select your "Data-Folder"
3. Select / Click on "List"
4. Scroll down to "Documents"
5. Select a document
6. Click on "edit record"
7. Click on "Save"
8. See the error

Expected Behavior

No error message

Screenshots and Examples

Environment

• OS version: Debian GNU/Linux 11 (bullseye)
• RDBMS version: MySQL 5.5.5-10.5.23-MariaDB-0+deb11u1
• Apache Solr version: 8.11.2
• TYPO3 version: 10.4.38
• PHP version: 7.4.33

Additional Context

Add any other context about the problem here.

[sebastian-meyer]

Did you change any of the pre-defined metadata mappings?

The error suggest that maybe some mapping is missing a mandatory namespace for an element...

[BFallert]

After a long time, I set about investigating this error again.
I made a few adjustments in MetsDocument.php to determine which elements are causing these messages.

private function setMetadataFieldValues(array $resArray, DOMXPath $domXPath, DOMElement $domNode, array &$metadata, array $subentryResults): void
{
    if ($resArray['format'] > 0 && !empty($resArray['xpath'])) {

        libxml_use_internal_errors(true); // Prevents direct error output
        try {
            $values = $domXPath->evaluate($resArray['xpath'], $domNode);
            
            // Check whether errors have occurred
            $errors = libxml_get_errors();
            foreach ($errors as $error) {
                if (strpos($error->message, 'Undefined namespace prefix') !== false) {
                    error_log("Warning: An undefined namespace prefix was used in XPath: " . $resArray['xpath']);
                };
            }
        } catch (Exception $e) {
            error_log("Error when evaluating XPath: " . $e->getMessage());
        };
        libxml_clear_errors(); // Deletes errors for the next use
        ...

I get the error from two elements

• Warning: An undefined namespace prefix was used in XPath: ./mods:name[@type="corporate"]/mods:namePart
• Warning: An undefined namespace prefix was used in XPath: ./mods:extension/ns3:ubma/ns3:branchindustry

I feel responsible for one of them" ./mods:extension/ns3:ubma/ns3:branchindustry

but I derived the second entry from example 2.2.3 in https://dfg-viewer.de/fileadmin/groups/dfgviewer/MODS_application_profile_2.3.1.pdf" ./mods:name[@type="corporate"]/mods:namePart

But I have no idea how to correct this two error?

[sebastian-meyer]

The first one seems odd.

All registered namespaces are represented by a record on the root level of the page tree. Could you please check if there is a record named "MODS" with the right namespace declaration?

[sebastian-meyer]

See here for the default values: https://github.com/kitodo/kitodo-presentation/blob/main/Resources/Private/Data/FormatDefaults.json