Implement review comments

Author: BartChris

Kitodo-DataManagement/src/main/java/org/kitodo/data/database/persistence/TaskDAO.java

@@ -11,7 +11,6 @@
 
 package org.kitodo.data.database.persistence;
 
-import java.util.ArrayList;
 import java.util.EnumMap;
 import java.util.HashMap;
 import java.util.List;
@@ -211,7 +210,7 @@ public Map<TaskStatus, Integer> countTaskStatusForProcessAndItsAncestors(Process
     public Map<Integer, EnumMap<TaskStatus, Integer>> loadTaskStatusCountsForProcesses(
             List<Integer> processIds) throws DAOException {
         Map<Integer, EnumMap<TaskStatus, Integer>> result = new HashMap<>();
-        if (processIds == null || processIds.isEmpty()) {
+        if (Objects.isNull(processIds) || processIds.isEmpty()) {
             return result;
         }
         Stopwatch stopwatch = new Stopwatch(this,"loadTaskStatusCountsForProcesses",
@@ -247,7 +246,7 @@ public Map<Integer, EnumMap<TaskStatus, Integer>> loadTaskStatusCountsForProcess
 
                 EnumMap<TaskStatus, Integer> map =
                         result.computeIfAbsent(rootId, id -> createEmptyStatusMap());
-                if (statusValue != null) {
+                if (Objects.nonNull(statusValue)) {
                     map.put(TaskStatus.getStatusFromValue(statusValue), count);
                 }
             }

Kitodo/src/main/java/org/kitodo/production/forms/ProcessListBaseView.java

@@ -68,12 +68,10 @@ public class ProcessListBaseView extends ValidatableForm {
     DeleteProcessDialog deleteProcessDialog = new DeleteProcessDialog();
 
     private final HashMap<Integer, Boolean> exportable = new HashMap<>();
-    private static final String NL = "\n";
 
     boolean allSelected = false;
     HashSet<Integer> excludedProcessIds = new HashSet<>();
 
-
     /**
      * Constructor.
      */
@@ -233,15 +231,16 @@ private void appendTitles(StringBuilder sb,
                               TaskStatus status,
                               Map<TaskStatus, List<String>> titles) {
         List<String> list = titles.get(status);
+        String newLine = "\n";
         if (Objects.isNull(list) || list.isEmpty()) {
             return;
         }
         if (!sb.isEmpty()) {
-            sb.append(NL);
+            sb.append(newLine);
         }
         sb.append(Helper.getTranslation(status.getTitle())).append(":");
         for (String t : list) {
-            sb.append(NL).append(" - ").append(Helper.getTranslation(t));
+            sb.append(newLine).append(" - ").append(Helper.getTranslation(t));
         }
     }
 

Kitodo/src/main/java/org/kitodo/production/model/LazyProcessModel.java

@@ -59,7 +59,7 @@ public class LazyProcessModel extends LazyBeanModel {
     private boolean showInactiveProjects = false;
 
     private Map<Integer, EnumMap<TaskStatus, Integer>> taskStatusCache = new HashMap<>();
-    public Map<Integer, Map<TaskStatus, List<String>>> taskTitleCache = new HashMap<>();
+    private Map<Integer, Map<TaskStatus, List<String>>> taskTitleCache = new HashMap<>();
     private Set<Integer> processesWithChildren = new HashSet<>();
 
     /**
@@ -187,14 +187,30 @@ public Object getRowData() {
         }
     }
 
+    /**
+     * Returns the cached task titles grouped by process ID and task status.
+     *
+     * @return map of process ID to task titles grouped by Taskstatus
+     */
     public Map<Integer, Map<TaskStatus, List<String>>> getTaskTitleCache() {
         return taskTitleCache;
     }
 
+    /**
+     * Returns the cached task status counts for the given process.
+     *
+     * @param process the process whose task status counts are requested
+     * @return map of TaskStatus to count
+     */
     public EnumMap<TaskStatus, Integer> getTaskStatusCounts(Process process) {
         return taskStatusCache.get(process.getId());
     }
 
+    /**
+     * Returns the IDs of processes that have at least one child process.
+     *
+     * @return set of process IDs with children
+     */
     public Set<Integer> getProcessesWithChildren() {
         return processesWithChildren;
     }

Kitodo/src/main/java/org/kitodo/production/services/data/ProcessService.java

@@ -2381,7 +2381,7 @@ public List<Task> getCurrentTasksForUser(Process process, User user) {
      * @return IDs of processes that have children
      */
     public Set<Integer> findProcessIdsWithChildren(Collection<Integer> processIds) throws DAOException {
-        if (processIds == null || processIds.isEmpty()) {
+        if (Objects.isNull(processIds) || processIds.isEmpty()) {
             return Collections.emptySet();
         }
         String hql = "SELECT DISTINCT p.parent "

Kitodo/src/main/webapp/WEB-INF/templates/includes/processes/progressColumn.xhtml

@@ -16,7 +16,6 @@
         xmlns:h="http://xmlns.jcp.org/jsf/html"
         xmlns:ui="http://xmlns.jcp.org/jsf/facelets">
     <!--@elvariable id="process" type="org.kitodo.production.dto.ProcessDTO"-->
-
     <h:panelGroup
             class="process-progress"
             title="#{ProcessForm.getCurrentTaskTitles(process)}"
@@ -42,6 +41,4 @@
                       + ProcessForm.progressInProcessing(process)
                       + ProcessForm.progressClosed(process)}%);"
     />
-
-
 </ui:composition>