Refactor Bean Scopes: Task List (#6906)

* Refactor process list and make it view scoped.

* Make selenium test work again. Fix extended search page for process search. Preserve select box state showInactiveProjects and showClosedProcesses as additional URL query parameters in process list view.

* Refactor kitodo script dialog and process list view statistics dialog into separate files.

* Remember last filter of process list in separate session scoped bean.

* Remove unnecessary file BatchListView.java.

* Remove ProcessListView from constructor of SearchForm, which is not required any more after bean scope refactoring of ProcessForm.

* Refactor CurrentTaskForm to view scoped edit and list view beans.

* Do not remove empty query parameters to distinguish empty filters from unspecified filters that are replaced with default values.

* Improve nagivation from and to task list, task edit view and task work view.

* Fix checkstyle issues.

* Fix integration test for TaskListView which doesn't call init method.

* Rename ProcessFormIT to ProcessListViewIT.

* Fix spelling mistakes in Javadoc.

* Update Javadoc and implement CodeQL suggestions.

* Fix referrer navigation to and from task edit view.

* Rename taskForm to taskListView in FilterMenu.java.

* Include @solth's review feedback cleaning up unused methods in ProcessListView and improving code style.

* Use utf8 from StandardCharsets when url encoding or decoding.

* Fix spelling error.

* Fix missing quote in processes.xhtml.

Co-authored-by: Arved Solth <solth@effective-webwork.de>

* Implement review feedback by @solth.

* Remove unused methods in TaskListView and minor code style fixes based on @solth's review.

---------

Co-authored-by: Arved Solth <solth@effective-webwork.de>

Author: thomaslow

Kitodo/src/main/java/org/kitodo/production/filters/FilterMenu.java

@@ -24,8 +24,8 @@
 
 import org.kitodo.production.enums.FilterPart;
 import org.kitodo.production.enums.FilterString;
-import org.kitodo.production.forms.CurrentTaskForm;
 import org.kitodo.production.forms.process.ProcessListView;
+import org.kitodo.production.forms.task.TaskListView;
 import org.kitodo.production.forms.user.UserListView;
 import org.kitodo.production.services.ServiceManager;
 import org.kitodo.production.services.data.FilterService;
@@ -75,7 +75,7 @@ public class FilterMenu {
     );
 
     private ProcessListView processListView = null;
-    private CurrentTaskForm taskForm = null;
+    private TaskListView taskListView = null;
     private UserListView userListView = null;
     private List<Suggestion> suggestions;
     private final List<ParsedFilter> parsedFilters;
@@ -95,10 +95,10 @@ public FilterMenu(ProcessListView processListView) {
     /**
      * Constructor of filter menu for tasks.
      *
-     * @param taskForm instance of CurrentTaskForm
+     * @param taskListView instance of TaskListView
      */
-    public FilterMenu(CurrentTaskForm taskForm) {
-        this.taskForm = taskForm;
+    public FilterMenu(TaskListView taskListView) {
+        this.taskListView = taskListView;
         suggestions = createSuggestionsForTaskCategory("");
         parsedFilters = new ArrayList<>();
     }
@@ -146,7 +146,7 @@ public void updateSuggestions(String input) {
             // category should be suggested
             if (Objects.nonNull(processListView)) {
                 suggestions = createSuggestionsForProcessCategory(input);
-            } else if (Objects.nonNull(taskForm)) {
+            } else if (Objects.nonNull(taskListView)) {
                 suggestions = createSuggestionsForTaskCategory(input);
             } else if (Objects.nonNull(userListView)) {
                 suggestions = createSuggestionsForUserCategory(input);
@@ -167,7 +167,7 @@ public void updateSuggestions(String input) {
                     String category = matcherPreviousCategory.find() ? matcherPreviousCategory.group() : "";
                     suggestions = createSuggestionsForProcessValue(checkFilterCategory(category, processCategories), lastPart);
                 }
-            } else if (Objects.nonNull(taskForm)) {
+            } else if (Objects.nonNull(taskListView)) {
                 if (matcherNextCategory.find()) {
                     // strings ends with " | "
                     suggestions = createSuggestionsForTaskCategory(matcherNextCategory.group());
@@ -397,8 +397,8 @@ public void updateFilters() {
         }
         if (Objects.nonNull(processListView)) {
             processListView.setFilter(newFilter.toString());
-        } else if (Objects.nonNull(taskForm)) {
-            taskForm.setFilter(newFilter.toString());
+        } else if (Objects.nonNull(taskListView)) {
+            taskListView.setFilter(newFilter.toString());
         } else if (Objects.nonNull(userListView)) {
             userListView.setFilter(newFilter.toString());
         }

Kitodo/src/main/java/org/kitodo/production/forms/BaseEditView.java

@@ -11,6 +11,10 @@
 
 package org.kitodo.production.forms;
 
+import java.net.URLDecoder;
+import java.nio.charset.StandardCharsets;
+import java.util.Objects;
+
 /**
  * Base class for an edit view.
  * 
@@ -37,8 +41,13 @@ public String getReferrerListOptions() {
      * @param referrerListOptions the referrer list options (URL query parameters)
      */
     public void setReferrerListOptionsFromTemplate(String referrerListOptions) {
-        this.referrerListOptions = referrerListOptions;
+        if (Objects.nonNull(referrerListOptions) && referrerListOptions.startsWith("_")) {
+            // referrerListOptions were URL encoded twice due to JSF's auto encoding of view paths
+            // manually decode them again
+            this.referrerListOptions = URLDecoder.decode(referrerListOptions.substring(1), StandardCharsets.UTF_8);
+        } else {
+            this.referrerListOptions = referrerListOptions;
+        }
     }
-
 
 }