Update eslint config and tests

Author: ItsOnlyBinary

eslint.config.js

@@ -1,28 +1,64 @@
-module.exports = {
-    root: true,
-    extends: [
-        'eslint:recommended',
-        'standard'
-    ],
-    parserOptions: {
-        sourceType: 'script',
+'use strict';
+
+const globals = require('globals');
+const eslintJS = require('@eslint/js');
+
+module.exports = [
+    eslintJS.configs.recommended,
+    {
+        languageOptions: {
+            sourceType: 'commonjs',
+            globals: {
+                ...globals.browser,
+                ...globals.node,
+            }
+        },
+        rules: {
+            'indent': ['error', 4],
+            'no-shadow': ['error'],
+            'no-var': ['error'],
+            'no-unused-vars': ['error', {
+                vars: 'all',
+                args: 'none',
+                caughtErrors: 'none',
+                ignoreRestSiblings: false,
+                ignoreUsingDeclarations: false,
+                reportUsedIgnorePattern: false,
+            }],
+            'operator-linebreak': ['error', 'after'],
+            'quote-props': ['error', 'consistent-as-needed'],
+            'quotes': ['error', 'single'],
+            'semi': ['error', 'always'],
+            'space-before-function-paren': ['error', 'never'],
+            'strict': ['error', 'safe']
+        },
     },
-    env: {
-        'browser': true,
-        'node': true,
+    {
+        files: ['test/**/*.mjs'],
+        languageOptions: {
+            sourceType: 'module',
+            globals: {
+                afterEach: 'readonly',
+                beforeEach: 'readonly',
+                describe: 'readonly',
+                it: 'readonly',
+            },
+        },
+        rules: {
+            'no-unused-expressions': 0,
+            'comma-dangle': ['error', {
+                arrays: 'always-multiline',
+                objects: 'always-multiline',
+                imports: 'never',
+                exports: 'never',
+                functions: 'ignore',
+            }],
+        },
     },
-    'rules': {
-        'camelcase': 0,
-        'comma-dangle': 0,
-        'indent': ['error', 4],
-        'new-cap': 0,
-        'no-shadow': ['error'],
-        'no-var': ['error'],
-        'operator-linebreak': ['error', 'after'],
-        'semi': ['error', 'always'],
-        'space-before-function-paren': ['error', 'never'],
-        'standard/no-callback-literal': 0,
-        'n/no-callback-literal': 0,
-        "object-shorthand": 0,
-    }
-};
+    {
+        files: ['examples/**/*.js'],
+        rules: {
+            strict: 0,
+        },
+    },
+];

src/commands/handlers/misc.js

@@ -364,9 +364,9 @@ function standardReply(command, handler) {
     handler.emit('standard reply', {
         type: command.command,
         command: cmd,
-        code,
-        context,
-        description,
+        code: code,
+        context: context,
+        description: description,
         tags: command.tags,
     });
 }

src/commands/numerics.js

@@ -1,6 +1,5 @@
 'use strict';
 
-/* eslint-disable quote-props */
 module.exports = {
     '001': 'RPL_WELCOME',
     '002': 'RPL_YOURHOST',

src/ircmessage.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const MessageTags = require('./messagetags');
 
 module.exports = class IrcMessage {

src/linebreak.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const GraphemeSplitter = require('grapheme-splitter');
 const { encode: encodeUTF8 } = require('isomorphic-textencoder');
 

test/casefolding.mjs

@@ -1,10 +1,9 @@
-'use strict';
-/* globals describe, it */
-const chai = require('chai');
-const IrcClient = require('../src/client');
-const expect = chai.expect;
+import { expect, use as chaiUse } from 'chai';
+import chaiSubset from 'chai-subset';
 
-chai.use(require('chai-subset'));
+import IrcClient from '../src/client.js';
+
+chaiUse(chaiSubset);
 
 describe('src/client.js', function() {
     describe('caseLower', function() {
@@ -69,7 +68,6 @@ describe('src/client.js', function() {
         });
     });
 
-    /* eslint-disable no-unused-expressions */
     describe('caseCompare', function() {
         it('CASEMAPPING=rfc1459', function() {
             const client = new IrcClient();

test/commands/handlers/misc.test.mjs

@@ -1,15 +1,12 @@
-'use strict';
+import { expect, use as chaiUse } from 'chai';
+import sinonChai from 'sinon-chai';
 
-/* globals describe, it */
-/* eslint-disable no-unused-expressions */
-const chai = require('chai');
-const expect = chai.expect;
-const mocks = require('../../mocks');
-const sinonChai = require('sinon-chai');
-const misc = require('../../../src/commands/handlers/misc');
-const IrcCommand = require('../../../src/commands/command');
+import * as mocks from '../../mocks.mjs';
 
-chai.use(sinonChai);
+import misc from '../../../src/commands/handlers/misc.js';
+import IrcCommand from '../../../src/commands/command.js';
+
+chaiUse(sinonChai);
 
 describe('src/commands/handlers/misc.js', function() {
     describe('PING handler', function() {
@@ -18,7 +15,7 @@ describe('src/commands/handlers/misc.js', function() {
             params: ['example.com'],
             tags: {
                 time: '2021-06-29T16:42:00Z',
-            }
+            },
         });
         mock.handlers.PING(cmd, mock.spies);
 
@@ -33,8 +30,8 @@ describe('src/commands/handlers/misc.js', function() {
                 message: undefined,
                 time: 1624984920000,
                 tags: {
-                    time: '2021-06-29T16:42:00Z'
-                }
+                    time: '2021-06-29T16:42:00Z',
+                },
             });
         });
     });
@@ -46,7 +43,7 @@ describe('src/commands/handlers/misc.js', function() {
                 params: ['one.example.com', 'two.example.com'],
                 tags: {
                     time: '2011-10-10T14:48:00Z',
-                }
+                },
             });
             mock.handlers.PONG(cmd, mock.spies);
             expect(mock.spies.network.addServerTimeOffset).to.have.been.calledOnce;
@@ -55,8 +52,8 @@ describe('src/commands/handlers/misc.js', function() {
                 message: 'two.example.com',
                 time: 1318258080000,
                 tags: {
-                    time: '2011-10-10T14:48:00Z'
-                }
+                    time: '2011-10-10T14:48:00Z',
+                },
             });
         });
     });

test/helper.test.mjs

@@ -1,11 +1,9 @@
-'use strict';
+import { expect, use as chaiUse } from 'chai';
+import chaiSubset from 'chai-subset';
 
-/* globals describe, it */
-const chai = require('chai');
-const Helper = require('../src/helpers');
-const expect = chai.expect;
+import Helper from '../src/helpers.js';
 
-chai.use(require('chai-subset'));
+chaiUse(chaiSubset);
 
 describe('src/irclineparser.js', function() {
     describe('mask parsing', function() {