Linting and tests update

Author: prawnsalad

.jshintrc

@@ -5,5 +5,6 @@
     "latedef": "nofunc",
     "noarg": true,
     "undef": true,
-    "unused": true
+    "unused": false,
+    "esnext": true
 }

examples/bot.js

@@ -8,7 +8,7 @@ var IRC = require('../');
 function NickservMiddleware() {
 	return function(client, raw_events, parsed_events) {
 		raw_events.use(theMiddleware);
-	}
+	};
 
 
 	function theMiddleware(command, event, client, next) {
@@ -33,7 +33,7 @@ function MyIrcMiddleware() {
 	return function(client, raw_events, parsed_events) {
 		parsed_events.use(theMiddleware);
 		client.requestCap('kiwiirc.com/user');
-	}
+	};
 
 
 	function theMiddleware(command, event, client, next) {

package.json

@@ -4,7 +4,6 @@
   "description": "A better IRC framework for node.js",
   "main": "index.js",
   "dependencies": {
-    "es6-set": "^0.1.3",
     "eventemitter3": "^2.0.2",
     "iconv-lite": "^0.4.11",
     "lodash": "^3.10.1",

src/commands/handlers/registration.js

@@ -60,7 +60,6 @@ var handlers = {
 
     CAP: function(command) {
         var request_caps = [];
-        var capabilities = [];
         var capability_values = Object.create(null);
 
         // TODO: capability modifiers

src/connection.js

@@ -170,14 +170,15 @@ Connection.prototype.write = function(data, callback) {
 Connection.prototype.setTimeout = function(/*fn, length, argN */) {
     var that = this;
     var tmr = null;
-    var callback = arguments[0];
+    var args = Array.prototype.slice.call(arguments, 0);
+    var callback = args[0];
 
-    arguments[0] = function() {
+    args[0] = function() {
        _.pull(that._timers, tmr);
-       callback.apply(null, arguments);
+       callback.apply(null, args);
     };
 
-    tmr = setTimeout.apply(null, arguments);
+    tmr = setTimeout.apply(null, args);
     this._timers.push(tmr);
     return tmr;
 };
@@ -242,7 +243,7 @@ Connection.prototype.processReadBuffer = function(continue_processing) {
     }
 
     var that = this;
-    var lines_per_js_tick = 4;
+    var lines_per_js_tick = 40;
     var processed_lines = 0;
     var line;
     var message;

src/transports/websocket.js

@@ -54,7 +54,7 @@ Connection.prototype.connect = function() {
     ws_addr += options.port ? ':' + options.port : '';
     ws_addr += options.path ? options.path : '';
 
-    socket = this.socket = new WebSocket(ws_addr);
+    socket = this.socket = new WebSocket(ws_addr); // jshint ignore:line
 
     socket.onopen = _.bind(function() {
         that.onSocketFullyConnected();

src/user.js

@@ -1,5 +1,3 @@
-var Set = require('es6-set');
-
 function User(opts) {
     opts = opts || {};
 

test/commands/handlers/misc.test.js

@@ -1,4 +1,6 @@
 /*globals describe, it */
+/* jshint -W024 */
+/* jshint expr:true */
 var chai = require('chai'),
     expect = chai.expect,
     mocks = require('../../mocks'),

test/helper.test.js

@@ -1,6 +1,7 @@
 "use strict";
+/*globals describe, it */
 let chai = require('chai'),
-    Helper = require('../src/helper'),
+    Helper = require('../src/helpers'),
     expect = chai.expect;
 
 chai.use(require('chai-subset'));