Skip to content

Commit b842191

Browse files
ItsOnlyBinaryItsOnlyBinary
committed
improve github workflows
1 parent 000b4aa commit b842191

File tree

2 files changed

+288
-18
lines changed

2 files changed

+288
-18
lines changed

‎.github/workflows/release.yml‎

Lines changed: 135 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,153 @@
11
name: Release
22

33
on:
4-
release:
5-
types: [published]
4+
workflow_dispatch:
5+
inputs:
6+
version:
7+
description: "Version to publish"
8+
required: true
9+
dry_run:
10+
description: "Perform a dry run without publishing"
11+
type: boolean
12+
required: false
13+
default: true
14+
15+
concurrency:
16+
group: npm-publish-${{ github.repository }}
17+
cancel-in-progress: false
618

719
jobs:
820
release:
921
name: Release workflow
10-
1122
runs-on: ubuntu-latest
1223

24+
permissions:
25+
contents: read
26+
id-token: write # Required for OIDC trusted publishing
27+
1328
steps:
14-
- uses: actions/checkout@v4
29+
- name: Validate GitHub release and tag exists
30+
env:
31+
GH_TOKEN: ${{ github.token }}
32+
run: |
33+
TAG="v${{ inputs.version }}"
34+
echo "Looking for release with tag $TAG..."
35+
36+
RELEASE=$(gh release view "$TAG" --repo ${{ github.repository }} --json tagName,name 2>/dev/null)
37+
if [ $? -ne 0 ]; then
38+
echo "❌ No GitHub release found with tag $TAG"
39+
exit 1
40+
fi
41+
42+
RELEASE_NAME=$(echo "$RELEASE" | jq -r '.name')
43+
if [ "$RELEASE_NAME" != "$TAG" ]; then
44+
echo "❌ Release name '$RELEASE_NAME' does not match expected '$TAG'"
45+
exit 1
46+
fi
47+
48+
echo "✅ GitHub release '$RELEASE_NAME' confirmed"
49+
50+
- name: Checkout tag
51+
uses: actions/checkout@v4
52+
with:
53+
ref: "v${{ inputs.version }}"
54+
fetch-depth: 0
55+
56+
- name: Ensure tag commit is on master
57+
run: |
58+
if ! git branch -r --contains "$(git rev-parse HEAD)" | grep -q "origin/master"; then
59+
echo "❌ Tag is not based on master branch"
60+
exit 1
61+
fi
62+
echo "✅ Tag commit is on master"
1563
1664
- name: Setup Node.js
1765
uses: actions/setup-node@v4
1866
with:
19-
node-version: '22.x'
20-
registry-url: 'https://registry.npmjs.org/'
67+
node-version: "lts/*"
68+
registry-url: "https://registry.npmjs.org/"
2169

22-
- name: Install
23-
run: yarn --frozen-lockfile --non-interactive
70+
- name: Enable Corepack
71+
run: corepack enable
72+
73+
- name: Detect Yarn version
74+
id: yarn-version
75+
run: |
76+
# Resolve the Yarn major version from the packageManager field in
77+
# package.json if present, otherwise fall back to the installed version.
78+
YARN_VERSION=$(node -p "
79+
try {
80+
const pm = require('./package.json').packageManager ?? '';
81+
const match = pm.match(/^yarn@(\d+)/);
82+
match ? match[1] : '';
83+
} catch { '' }
84+
")
85+
if [ -z "$YARN_VERSION" ]; then
86+
YARN_VERSION=$(yarn --version | cut -d. -f1)
87+
fi
88+
echo "major=$YARN_VERSION" >> "$GITHUB_OUTPUT"
89+
echo "Detected Yarn major version: $YARN_VERSION"
90+
91+
- name: Validate version matches package.json
92+
run: |
93+
PKG_VERSION=$(node -p "require('./package.json').version")
94+
INPUT_VERSION="${{ inputs.version }}"
95+
if [ "$PKG_VERSION" != "$INPUT_VERSION" ]; then
96+
echo "❌ Version mismatch: package.json has $PKG_VERSION but input was $INPUT_VERSION"
97+
exit 1
98+
fi
99+
echo "✅ Version $PKG_VERSION confirmed"
100+
101+
- name: Install dependencies
102+
run: |
103+
if [ "${{ steps.yarn-version.outputs.major }}" = "1" ]; then
104+
yarn install --frozen-lockfile --non-interactive
105+
else
106+
yarn install --immutable
107+
fi
108+
109+
- name: Build package (if build script exists)
110+
run: |
111+
if node -e "process.exit(require('./package.json').scripts?.build ? 0 : 1)" 2>/dev/null; then
112+
yarn build
113+
else
114+
echo "No build script found — skipping build step"
115+
fi
116+
117+
- name: Publish (dry run)
118+
if: ${{ inputs.dry_run }}
119+
env:
120+
# The npm CLI automatically detects the OIDC environment via
121+
# ACTIONS_ID_TOKEN_REQUEST_URL / ACTIONS_ID_TOKEN_REQUEST_TOKEN and
122+
# handles the token exchange itself. NODE_AUTH_TOKEN must still be set
123+
# (even if empty) to satisfy the .npmrc written by actions/setup-node,
124+
# otherwise npm errors before it reaches OIDC auth.
125+
NODE_AUTH_TOKEN: ""
126+
run: npm publish --provenance --access public --dry-run
24127

25128
- name: Publish
26-
run: yarn publish
129+
if: ${{ !inputs.dry_run }}
27130
env:
28-
NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
131+
NODE_AUTH_TOKEN: ""
132+
run: npm publish --provenance --access public
133+
134+
- name: Verify published version
135+
if: ${{ !inputs.dry_run }}
136+
run: |
137+
PACKAGE_NAME=$(node -p "require('./package.json').name")
138+
EXPECTED_VERSION="${{ inputs.version }}"
139+
140+
echo "Waiting for npm propagation..."
141+
142+
for i in {1..10}; do
143+
PUBLISHED_VERSION=$(npm view "$PACKAGE_NAME" version 2>/dev/null)
144+
if [ "$PUBLISHED_VERSION" = "$EXPECTED_VERSION" ]; then
145+
echo "✅ Version $PUBLISHED_VERSION confirmed on npm"
146+
exit 0
147+
fi
148+
echo "Not visible yet (attempt $i)..."
149+
sleep 15
150+
done
151+
152+
echo "❌ Published version not visible after waiting"
153+
exit 1

‎.github/workflows/tests.yml‎

Lines changed: 153 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,135 @@ name: Tests
33
on: [push, pull_request]
44

55
jobs:
6-
build:
6+
resolve-node-versions:
7+
runs-on: ubuntu-latest
8+
outputs:
9+
matrix: ${{ steps.set-matrix.outputs.matrix }}
10+
steps:
11+
- id: set-matrix
12+
run: |
13+
node <<'EOF' >> $GITHUB_OUTPUT
14+
const https = require('https');
15+
const fs = require('fs');
16+
17+
function compareSemver(a, b) {
18+
const pa = a.split('.').map(Number);
19+
const pb = b.split('.').map(Number);
20+
for (let i = 0; i < 3; i++) {
21+
if ((pa[i] ?? 0) !== (pb[i] ?? 0)) return (pb[i] ?? 0) - (pa[i] ?? 0);
22+
}
23+
return 0;
24+
}
25+
26+
// Returns { major, minor, patch, minorSpecified, patchSpecified } or null
27+
function parseEnginesVersion(enginesNode) {
28+
if (!enginesNode) return null;
29+
const match = enginesNode.match(/>=\s*(\d+)(?:\.(\d+)(?:\.(\d+))?)?/);
30+
if (!match) return null;
31+
return {
32+
major: parseInt(match[1], 10),
33+
minor: match[2] !== undefined ? parseInt(match[2], 10) : null,
34+
patch: match[3] !== undefined ? parseInt(match[3], 10) : null,
35+
minorSpecified: match[2] !== undefined,
36+
patchSpecified: match[3] !== undefined,
37+
};
38+
}
39+
40+
let enginesNode = null;
41+
try {
42+
const pkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
43+
enginesNode = pkg?.engines?.node ?? null;
44+
} catch {}
45+
46+
const minVersion = parseEnginesVersion(enginesNode);
47+
48+
https.get('https://nodejs.org/dist/index.json', res => {
49+
let data = '';
50+
res.on('data', chunk => data += chunk);
51+
res.on('end', () => {
52+
const releases = JSON.parse(data);
53+
54+
// Filter LTS only, strip 'v' prefix
55+
const lts = releases
56+
.filter(r => r.lts)
57+
.map(r => r.version.replace(/^v/, ''));
58+
59+
// Group by major, pick highest semver per major
60+
const byMajor = {};
61+
for (const v of lts) {
62+
const major = parseInt(v.split('.')[0], 10);
63+
if (!byMajor[major]) byMajor[major] = [];
64+
byMajor[major].push(v);
65+
}
66+
67+
const latestPerMajor = Object.entries(byMajor)
68+
.map(([major, versions]) => {
69+
versions.sort(compareSemver);
70+
return { major: parseInt(major, 10), version: versions[0] };
71+
});
72+
73+
// Sort majors descending
74+
latestPerMajor.sort((a, b) => b.major - a.major);
75+
76+
// Take latest 4 LTS majors
77+
const top4 = latestPerMajor.slice(0, 4);
78+
const includedVersions = new Set(top4.map(e => e.version));
79+
const extra = [];
80+
81+
if (minVersion !== null) {
82+
// Resolve the exact minimum version string to test:
83+
// - patch specified (>= 18.18.2): use exactly 18.18.2
84+
// - minor specified, no patch (>= 18.18): use latest 18.18.x
85+
// - only major (>= 18): use latest 18.x.x (same as latestPerMajor entry)
86+
let minExact = null;
787
88+
if (minVersion.patchSpecified) {
89+
// Use the exact version if it exists in LTS releases
90+
const candidate = `${minVersion.major}.${minVersion.minor}.${minVersion.patch}`;
91+
if (lts.includes(candidate)) minExact = candidate;
92+
} else if (minVersion.minorSpecified) {
93+
// Find the latest patch for this major.minor
94+
const candidates = lts.filter(v => {
95+
const [maj, min] = v.split('.').map(Number);
96+
return maj === minVersion.major && min === minVersion.minor;
97+
});
98+
candidates.sort(compareSemver);
99+
if (candidates.length > 0) minExact = candidates[0]; // highest patch
100+
}
101+
// If only major specified, minExact stays null — latestPerMajor already covers it
102+
103+
// Add the resolved minimum version if not already included
104+
if (minExact && !includedVersions.has(minExact)) {
105+
extra.push({ major: minVersion.major, version: minExact });
106+
includedVersions.add(minExact);
107+
}
108+
109+
// Always also add the latest patch of the minimum major if not already included
110+
const latestOfMinMajor = latestPerMajor.find(e => e.major === minVersion.major);
111+
if (latestOfMinMajor && !includedVersions.has(latestOfMinMajor.version)) {
112+
extra.push(latestOfMinMajor);
113+
includedVersions.add(latestOfMinMajor.version);
114+
}
115+
}
116+
117+
// Merge and sort ascending (oldest -> newest)
118+
const all = [...top4, ...extra];
119+
all.sort((a, b) => compareSemver(b.version, a.version));
120+
121+
const matrix = { "node-version": all.map(e => e.version) };
122+
console.log(`matrix=${JSON.stringify(matrix)}`);
123+
});
124+
});
125+
EOF
126+
127+
test:
128+
needs: resolve-node-versions
8129
runs-on: ubuntu-latest
9130

10131
strategy:
11-
matrix:
12-
node-version: [18.x, 20.x, 22.x, 24.x]
132+
fail-fast: false
133+
matrix: ${{ fromJson(needs.resolve-node-versions.outputs.matrix) }}
134+
name: Node ${{ matrix.node-version }}
13135

14136
steps:
15137
- uses: actions/checkout@v4
@@ -18,13 +140,36 @@ jobs:
18140
uses: actions/setup-node@v4
19141
with:
20142
node-version: ${{ matrix.node-version }}
21-
cache: 'yarn'
22143

23-
- name: Install dependencies
24-
run: yarn --frozen-lockfile --non-interactive --prefer-offline
144+
- name: Enable Corepack
145+
run: corepack enable
25146

26-
- name: Test
27-
run: yarn test
147+
- name: Detect Yarn version
148+
id: yarn-version
149+
run: |
150+
YARN_VERSION=$(node -p "
151+
try {
152+
const pm = require('./package.json').packageManager ?? '';
153+
const match = pm.match(/^yarn@(\d+)/);
154+
match ? match[1] : '';
155+
} catch { '' }
156+
")
157+
if [ -z "$YARN_VERSION" ]; then
158+
YARN_VERSION=$(yarn --version | cut -d. -f1)
159+
fi
160+
echo "major=$YARN_VERSION" >> "$GITHUB_OUTPUT"
161+
echo "Detected Yarn major version: $YARN_VERSION"
162+
163+
- name: Install dependencies
164+
run: |
165+
if [ "${{ steps.yarn-version.outputs.major }}" = "1" ]; then
166+
yarn install --frozen-lockfile --non-interactive --prefer-offline
167+
else
168+
yarn install --immutable
169+
fi
28170
29171
- name: Lint
30172
run: yarn lint
173+
174+
- name: Test
175+
run: yarn test

0 commit comments

Comments
 (0)