Fix sasl 'capability_missing' detection (#354)

ItsOnlyBinary · web-flow · commit e6b3ded6ab5a · 2023-01-30T14:31:52.000Z
diff --git a/src/commands/handlers/registration.js b/src/commands/handlers/registration.js
@@ -218,7 +218,7 @@ const handlers = {
                         // emit 'sasl failed' with reason 'unsupported_mechanism' and disconnect if requested
                         handleSaslFail(handler, 'unsupported_mechanism');
                     }
-                } else if (handler.connection.options.account) {
+                } else if (saslAuth || handler.connection.options.sasl_mechanism === 'EXTERNAL') {
                     // The client provided an account for SASL auth but the server did not offer the SASL cap
                     // emit 'sasl failed' with reason 'capability_missing' and disconnect if requested
                     handleSaslFail(handler, 'capability_missing');

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ const handlers = {`
`218`	`218`	`// emit 'sasl failed' with reason 'unsupported_mechanism' and disconnect if requested`
`219`	`219`	`handleSaslFail(handler, 'unsupported_mechanism');`
`220`	`220`	`}`
`221`		`- } else if (handler.connection.options.account) {`
	`221`	`+ } else if (saslAuth \|\| handler.connection.options.sasl_mechanism === 'EXTERNAL') {`
`222`	`222`	`// The client provided an account for SASL auth but the server did not offer the SASL cap`
`223`	`223`	`// emit 'sasl failed' with reason 'capability_missing' and disconnect if requested`
`224`	`224`	`handleSaslFail(handler, 'capability_missing');`