Merge pull request #34 from kiwilan/develop

v2.1.01

Author: ewilan-riviere

composer.json

@@ -1,6 +1,6 @@
 {
     "name": "kiwilan/php-archive",
-    "version": "2.1.0",
+    "version": "2.1.01",
     "description": "PHP package to handle archives (.zip, .rar, .tar, .7z) or .pdf with hybrid solution (native/p7zip), designed to works with eBooks (.epub, .cbz, .cbr, .cb7, .cbt).",
     "keywords": [
         "php",

src/Models/PdfMeta.php

@@ -20,8 +20,12 @@ public function __construct(
     ) {
     }
 
-    public static function make(array $details): self
+    public static function make(?array $details): self
     {
+        if (! $details) {
+            return new self();
+        }
+
         $title = $details['Title'] ?? null;
         $author = $details['Author'] ?? null;
         $subject = $details['Subject'] ?? null;
@@ -49,6 +53,10 @@ public static function make(array $details): self
             pages: $pages,
         );
 
+        if (! $keywords) {
+            return $self;
+        }
+
         if (is_array($keywords)) {
             $keywords = implode(',', $keywords);
         }

tests/PdfTest.php

@@ -1,6 +1,8 @@
 <?php
 
 use Kiwilan\Archive\Archive;
+use Kiwilan\Archive\Enums\ArchiveEnum;
+use Kiwilan\Archive\Readers\ArchivePdf;
 
 beforeEach(function () {
     recurseRmdir(outputPath());
@@ -64,3 +66,19 @@
     expect($pdf->toArray())->toBeArray();
     expect($pdf->toJson())->toBeString();
 });
+
+it('can read empty pdf', function () {
+    $archive = Archive::read(PDF_EMPTY);
+
+    expect($archive)->toBeInstanceOf(ArchivePdf::class);
+    expect($archive->getType())->toBe(ArchiveEnum::pdf);
+});
+
+it('can read simple pdf', function () {
+    $archive = Archive::read(PDF_SIMPLE);
+    ray($archive);
+
+    expect($archive)->toBeInstanceOf(ArchivePdf::class);
+    expect($archive->getPdf()->getTitle())->toBeString();
+    expect($archive->getType())->toBe(ArchiveEnum::pdf);
+});

tests/Pest.php

@@ -7,7 +7,9 @@
 define('TARBZ2', __DIR__.'/media/archive.tar.bz2');
 define('TARGZ', __DIR__.'/media/archive.tar.gz');
 define('ZIP', __DIR__.'/media/archive.zip');
-define('PDF', __DIR__.'/media/example.pdf');
+define('PDF', __DIR__.'/media/pdf-example.pdf');
+define('PDF_SIMPLE', __DIR__.'/media/pdf-simple.pdf');
+define('PDF_EMPTY', __DIR__.'/media/pdf-empty.pdf');
 
 define('ARCHIVES', [
     'SEVENZIP' => SEVENZIP,

tests/media/README.md

@@ -37,7 +37,7 @@ exiftool \
   -Producer="Vue" \
   -Subject="Vue3 Composition API" \
   -Title="Vue3 Composition API" \
-  "./example.pdf"
+  "./pdf-example.pdf"
 ```
 
 ```bash