Filter social auths only for 'github-app' instead of using .first()

Fixes KIWI-TCMS-P5, https://kiwitcms.sentry.io/issues/5501934208/?project=277775

To reproduce the original bug:

1) Login via Google OAuth - uid is recorded as the email address
2) Login via GitHhub App integration - uid is an integer
3) Try editing the GitHub App via PLUGINS -> GitHub Integration ->
   Settings

The first social_auth record will be picked up and will lead to a
ValueError b/c the query expects an integer, not a string!

With this commit the code will search for record where
provider='github-app' because this is what it needs!

Author: atodorov

tcms_github_app/admin.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2019-2020 Alexander Todorov <[email protected]>
+# Copyright (c) 2019-2024 Alexander Todorov <[email protected]>
 #
 # Licensed under GNU Affero General Public License v3 or later (AGPLv3+)
 # https://www.gnu.org/licenses/agpl-3.0.html
@@ -107,7 +107,7 @@ def has_change_permission(self, request, obj=None):
         if not obj:
             return False
 
-        social_user = request.user.social_auth.first()
+        social_user = request.user.social_auth.filter(provider='github-app').first()
         if not social_user:
             return False
 

tcms_github_app/middleware.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2019-2022 Alexander Todorov <[email protected]>
+# Copyright (c) 2019-2024 Alexander Todorov <[email protected]>
 #
 # Licensed under GNU Affero General Public License v3 or later (AGPLv3+)
 # https://www.gnu.org/licenses/agpl-3.0.html
@@ -30,8 +30,8 @@ def __call__(self, request):
             return self.get_response(request)
 
         app_inst = None
-        social_user = request.user.social_auth.first()
-        if social_user and social_user.uid.isdigit():
+        social_user = request.user.social_auth.filter(provider='github-app').first()
+        if social_user:
             app_inst = AppInstallation.objects.filter(
                 sender=social_user.uid,
                 tenant_pk=None

tcms_github_app/utils.py

@@ -121,7 +121,7 @@ def find_installations(request):
     # if there are more than 1 (usually on public) then try to find the installation
     # performed by the current user, e.g. on their own account
     if installations.count() > 1:
-        social_user = request.user.social_auth.first()
+        social_user = request.user.social_auth.filter(provider='github-app').first()
         if social_user:
             installations = installations.filter(sender=social_user.uid)
 

tcms_github_app/views.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2019-2021 Alexander Todorov <[email protected]>
+# Copyright (c) 2019-2024 Alexander Todorov <[email protected]>
 #
 # Licensed under GNU Affero General Public License v3 or later (AGPLv3+)
 # https://www.gnu.org/licenses/agpl-3.0.html
@@ -41,7 +41,7 @@ class ApplicationEdit(View):  # pylint: disable=missing-permission-required
             a ``@permission_required`` decorator here!
     """
     def get(self, request, *args, **kwargs):
-        social_user = request.user.social_auth.first()
+        social_user = request.user.social_auth.filter(provider='github-app').first()
         if not social_user:
             github_url = reverse('social:begin', args=['github-app'])
             messages.add_message(