fixup! experimental: dcz support in output handler

kjdev · kjdev · commit d362d8580d13 · 2025-08-08T11:12:14.000+09:00
diff --git a/zstd.c b/zstd.c
@@ -1349,6 +1349,7 @@ php_zstd_output_handler_load_dict(php_zstd_context *ctx)
                                      "request(%s) != actual(%s)",
                                      Z_STRVAL_P(available), ZSTR_VAL(b64));
                     PHP_ZSTD_G(compression_coding) &= ~PHP_ZSTD_ENCODING_DCZ;
+                    zend_string_release(data);
                     data = NULL;
                 }
                 zend_string_free(b64);
@@ -1357,6 +1358,7 @@ php_zstd_output_handler_load_dict(php_zstd_context *ctx)
             php_error_docref(NULL, E_WARNING,
                              "zstd: not found available-dictionary");
             PHP_ZSTD_G(compression_coding) &= ~PHP_ZSTD_ENCODING_DCZ;
+            zend_string_release(data);
             data = NULL;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -1349,6 +1349,7 @@ php_zstd_output_handler_load_dict(php_zstd_context *ctx)`
`1349`	`1349`	`"request(%s) != actual(%s)",`
`1350`	`1350`	`Z_STRVAL_P(available), ZSTR_VAL(b64));`
`1351`	`1351`	`PHP_ZSTD_G(compression_coding) &= ~PHP_ZSTD_ENCODING_DCZ;`
	`1352`	`+ zend_string_release(data);`
`1352`	`1353`	`data = NULL;`
`1353`	`1354`	`}`
`1354`	`1355`	`zend_string_free(b64);`
`@@ -1357,6 +1358,7 @@ php_zstd_output_handler_load_dict(php_zstd_context *ctx)`
`1357`	`1358`	`php_error_docref(NULL, E_WARNING,`
`1358`	`1359`	`"zstd: not found available-dictionary");`
`1359`	`1360`	`PHP_ZSTD_G(compression_coding) &= ~PHP_ZSTD_ENCODING_DCZ;`
	`1361`	`+ zend_string_release(data);`
`1360`	`1362`	`data = NULL;`
`1361`	`1363`	`}`
`1362`	`1364`	`}`