some fixes and cleaning up

Author: kjerandp

README.md

@@ -31,24 +31,24 @@ Both these types offer convenience functions for creating new instances, to make
 // 2d vectors - these statements produce the same result
 const v = new Vector(2, 1); // => [2, 1]
 const v = new Vector([2, 1]); // array as input
-const v = new Vector(2).fill(2, 1); // first arg is dimensions 
+const v = new Vector(2).copyFrom(2, 1); // first arg is dimensions 
 const v = vec2(2, 1); // creator function
 
 // 3d vectors - these statements produce the same result
 const v = new Vector(2, 0, 1); // => [2, 0, 1]
 const v = new Vector([2, 0, 1]); // array as input
-const v = new Vector(3).fill(2, 0, 1); // first arg is dimensions 
+const v = new Vector(3).copyFrom(2, 0, 1); // first arg is dimensions 
 const v = vec3(2, 0, 1); // creator function
 
 // 4d vectors - these statements produce the same result
 const v = new Vector(2, 2, 0, 1); // => [2, 2, 0, 1]
 const v = new Vector([2, 2, 0, 1]); // array as input
-const v = new Vector(4).fill(2, 2, 0, 1); // first arg is dimensions 
+const v = new Vector(4).copyFrom(2, 2, 0, 1); // first arg is dimensions 
 const v = vec4(2, 2, 0, 1); // creator function
 const v = vec4(vec3([2, 2], 0), 1); // combining arguments
 
 // constructing a 2x2 matrix and filling it with values top left to bottom right
-const m = new Matrix(2, 2).fill(1, 2, 3, 4); 
+const m = new Matrix(2, 2).copyFrom(1, 2, 3, 4); 
 
 // passing the values as a 2d array to the constructor gives the same result
 const m = new Matrix([
@@ -147,7 +147,7 @@ const T = tran(M); // immutable
 // +++
 ```
 
-(to be continued)
+Proper docs will be available soon. For more info please look at the tests or [this live sample](https://observablehq.com/@kjerandp/affine-transformations).
 
 
 ## License

package-lock.json

@@ -1,7 +1,7 @@
 {
   "private": false,
   "name": "@kjerandp/linear-algebra",
-  "version": "0.2.1-alpha.4",
+  "version": "0.2.1",
   "description": "Math library for doing basic linear algebra operations",
   "repository": "https://github.com/kjerandp/linear-algebra",
   "author": "Kjerand Pedersen",

package.json

@@ -1,17 +1,3 @@
-
-// import * as vector from './vector';
-// import * as matrix from './matrix';
-// import * as functions from './functions';
-// import * as constants from './constants';
-
-// export default {
-//   ...vector,
-//   ...matrix,
-//   ...functions,
-//   ...constants,
-// };
-
-
 export * from './vector';
 export * from './matrix';
 export * from './functions';

src/index.js

@@ -1,3 +1,8 @@
+/**
+ * Plan to use interface for all matrix value operations,
+ * but using more optimised versions for plain js numbers for now.
+ */
+
 // import factory from './factory';
 import factory from '../optimalisations/factory';
 

src/math/index.js

@@ -63,7 +63,7 @@ export class Matrix {
     if (values.length === 1 && op.isDefined(values[0])) {
       assignTo2d(this._values, () => values[0]);
     } else {
-      copyTo2d(this._values, values);
+      copyTo2d(this._values, argumentsToList(values));
     }
     return this;
   }

src/matrix.js

@@ -1,8 +1,5 @@
 
 export function argumentsToList(arg, rec = true, values = []) {
-  if (arg && arg.length === 1 && Array.isArray(arg[0])) {
-    [arg] = arg;
-  }
   if (arg && arg._values) {
     arg = arg._values;
   }

src/utils.js

@@ -74,7 +74,7 @@ export class Vector {
     if (values.length === 1 && Number.isFinite(values[0])) {
       assignTo1d(this._values, () => values[0]);
     } else {
-      copyTo1d(this._values, values);
+      copyTo1d(this._values, argumentsToList(values));
     }
     return this;
   }

src/vector.js

@@ -9,7 +9,7 @@ import {
   row2,
   row4,
 } from '../src/matrix';
-import { vec3, vec4 } from '../src/vector';
+import { vec2, vec3, vec4 } from '../src/vector';
 import { range } from '../src/utils';
 import op from '../src/math';
 // import { timer } from './timer';
@@ -32,6 +32,12 @@ describe('Matrix class tests', () => {
     expect(m.cols).toBe(2);
     expect(m.toArray(1)).toEqual([1, 1, 0, 0]);
 
+    m.copyFrom(vec4(vec2(1, 2), 3, 4));
+    expect(m.toArray()).toEqual([1, 2, 3, 4]);
+
+    m.copyFrom([[1, 2], 3, 4]);
+    expect(m.toArray()).toEqual([1, 2, 3, 4]);
+
     m = mat2(1, 2, 3, 4);
     expect(m.toArray(2)).toEqual([
       [1, 2],

test/matrix.spec.js

@@ -69,6 +69,10 @@ describe('Vector class tests', () => {
     v = vec4(1, 2, 3, 4);
     expect(v.dim).toBe(4);
     expect(v.toArray()).toEqual([1, 2, 3, 4]);
+
+    v = vec4(vec2(2, 2), 7, [1]);
+    expect(v.toArray()).toEqual([2, 2, 7, 1]);
+
   });
 
   it('Can clone/copy vectors', () => {