Fix many errors shown by analysis tool

Author: Rowan James

OpenRecentController.m

@@ -119,7 +119,7 @@ - (BOOL)control:(NSControl*)control textView:(NSTextView*)textView doCommandBySe
 
 - (id)tableView:(NSTableView *)aTableView objectValueForTableColumn:(NSTableColumn *)aTableColumn row:(int)rowIndex
 {	
-    id theValue;
+    id theValue = nil;
     NSParameterAssert(rowIndex >= 0 && rowIndex < [currentResults count]);
 
     NSURL* row = [currentResults objectAtIndex:rowIndex];

PBChangedFile.m

@@ -15,10 +15,11 @@ @implementation PBChangedFile
 
 - (id) initWithPath:(NSString *)p
 {
-	if (![super init])
-		return nil;
-
-	path = p;
+    self = [super init];
+    
+    if (self) {
+        path = p;
+    }
 	return self;
 }
 

PBDiffWindowController.m

@@ -17,10 +17,11 @@ @implementation PBDiffWindowController
 
 - (id) initWithDiff:(NSString *)aDiff
 {
-	if (![super initWithWindowNibName:@"PBDiffWindow"])
-		return nil;
+    self = [super initWithWindowNibName:@"PBDiffWindow"];
 
-	diff = aDiff;
+    if (self)
+        diff = aDiff;
+    
 	return self;
 }
 

PBEasyPipe.m

@@ -115,7 +115,7 @@ + (NSString*) outputForCommand: (NSString*) cmd withArgs: (NSArray*) args  inDir
 
 	[task launch];
 	// This can cause a "Bad file descriptor"... when?
-	NSData *data;
+	NSData *data = nil;
 	@try {
 		data = [handle readDataToEndOfFile];
 	}

PBGitHistoryGrapher.m

@@ -16,6 +16,8 @@ @implementation PBGitHistoryGrapher
 
 - (id) initWithBaseCommits:(NSSet *)commits viewAllBranches:(BOOL)viewAll queue:(NSOperationQueue *)queue delegate:(id)theDelegate
 {
+    self = [super init];
+
 	delegate = theDelegate;
 	currentQueue = queue;
 	searchSHAs = [NSMutableSet setWithSet:commits];

PBGitHistoryList.m

@@ -45,6 +45,8 @@ @implementation PBGitHistoryList
 
 - (id) initWithRepository:(PBGitRepository *)repo
 {
+    self = [super init];
+    
 	commits = [NSMutableArray array];
 	repository = repo;
 	lastBranchFilter = -1;

PBGitRepositoryWatcher.m

@@ -45,8 +45,9 @@ @implementation PBGitRepositoryWatcher
 @synthesize repository;
 
 - (id) initWithRepository:(PBGitRepository *)theRepository {
-    if (self != [super init])
-		return nil;
+    self = [super init];
+    if (!self)
+        return nil;
 
 	repository = theRepository;
 	FSEventStreamContext context = {0, self, NULL, NULL, NULL};

PBGitRevSpecifier.m

@@ -18,6 +18,7 @@ @implementation PBGitRevSpecifier
 // internal designated init
 - (id) initWithParameters:(NSArray *)params description:(NSString *)descrip
 {
+    self = [super init];
 	parameters = params;
 	description = descrip;
 
@@ -38,18 +39,21 @@ - (id) initWithParameters:(NSArray *)params description:(NSString *)descrip
 
 - (id) initWithParameters:(NSArray *)params
 {
+    self = [super init];
 	[self initWithParameters:params description:nil];
 	return self;
 }
 
 - (id) initWithRef:(PBGitRef *)ref
 {
+    self = [super init];
 	[self initWithParameters:[NSArray arrayWithObject:ref.ref] description:ref.shortName];
 	return self;
 }
 
 - (id) initWithCoder:(NSCoder *)coder
 {
+    self = [super init];
 	[self initWithParameters:[coder decodeObjectForKey:@"Parameters"] description:[coder decodeObjectForKey:@"Description"]];
 	return self;
 }