Skip to content

Commit c67bdf7

Browse files
committed
Fix a couple of instances of mix-and-matched @synthesize getters/setters
As part of ongoing work for ARC conversion (brotherbard#5)
1 parent b9b07f7 commit c67bdf7

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

PBGitHistoryController.m

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ - (void)saveSplitViewPosition;
4444

4545

4646
@implementation PBGitHistoryController
47-
@synthesize selectedCommitDetailsIndex, webCommit, gitTree, commitController, refController;
47+
@synthesize webCommit, gitTree, commitController, refController;
4848
@synthesize searchController;
4949
@synthesize commitList;
5050
@synthesize treeController;
@@ -187,6 +187,11 @@ - (void) setSelectedCommitDetailsIndex:(int)detailsIndex
187187
[self updateKeys];
188188
}
189189

190+
- (int) selectedCommitDetailsIndex
191+
{
192+
return selectedCommitDetailsIndex;
193+
}
194+
190195
- (void) updateStatus
191196
{
192197
self.isBusy = repository.revisionList.isUpdating;

PBGitIndex.m

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ - (void)postOperationFailed:(NSString *)description;
5656

5757
@implementation PBGitIndex
5858

59-
@synthesize amend;
60-
6159
- (id)initWithRepository:(PBGitRepository *)theRepository workingDirectory:(NSURL *)theWorkingDirectory
6260
{
6361
if (!(self = [super init]))
@@ -113,6 +111,11 @@ - (void)setAmend:(BOOL)newAmend
113111

114112
}
115113

114+
- (BOOL) amend
115+
{
116+
return amend;
117+
}
118+
116119
- (void)refresh
117120
{
118121
// If we were already refreshing the index, we don't want

PBSourceViewItem.m

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#import "PBGitRef.h"
1212

1313
@implementation PBSourceViewItem
14-
@synthesize parent, title, isGroupItem, children, revSpecifier, isUncollapsible;
14+
@synthesize parent, isGroupItem, children, revSpecifier, isUncollapsible;
1515
@dynamic icon;
1616

1717
- (id)init
@@ -122,6 +122,11 @@ - (NSString *)title
122122
return [[revSpecifier description] lastPathComponent];
123123
}
124124

125+
- (void) setTitle:(NSString *)_title
126+
{
127+
title = [_title retain];
128+
}
129+
125130
- (NSString *) stringValue
126131
{
127132
return self.title;

0 commit comments

Comments
 (0)