Merge pull request #649 from Kr0emer/fix/bug-005-rsa-zero-modulus

fix(rsa): reject zero-modulus JWK keys and throw on BigInteger divide-by-zero

Author: kjur

ext/jsbn.js

@@ -354,7 +354,7 @@ function bnpSquareTo(r) {
 // r != q, this != m.  q or r may be null.
 function bnpDivRemTo(m,q,r) {
   var pm = m.abs();
-  if(pm.t <= 0) return;
+  if(pm.t <= 0) throw "BigInteger divide by zero";
   var pt = this.abs();
   if(pt.t < pm.t) {
     if(q != null) q.fromInt(0);

ext/rsa.js

@@ -167,6 +167,15 @@ function RSASetPublic(N, E) {
     } else {
 	throw "Invalid RSA public key";
     }
+
+    if (this.n == null ||
+	typeof this.n.compareTo !== "function" ||
+	this.n.compareTo(BigInteger.ONE) <= 0 ||
+	this.e == null ||
+	isNaN(this.e) ||
+	this.e <= 0) {
+	throw "Invalid RSA public key";
+    }
 }
 
 // Perform raw public operation on "x": return x^e (mod n)

test/qunit-do-crypto.html

@@ -232,6 +232,31 @@
   equal(n, 100, "100 times success:" + n0 + ":" + n1 + ":" + n2 + ":" + n3);
 });
 
+test("RSASetPublic rejects zero modulus", function() {
+  throws(function() {
+    var pub = new RSAKey();
+    pub.setPublic("00", "10001");
+  },
+  "Invalid RSA public key",
+  "reject zero modulus");
+});
+
+test("KEYUTIL.getKey rejects JWK with zero modulus", function() {
+  throws(function() {
+    KEYUTIL.getKey({kty: "RSA", n: "AA", e: "AQAB"});
+  },
+  "Invalid RSA public key",
+  "reject JWK n=0");
+});
+
+test("BigInteger.modPowInt throws when modulus is zero", function() {
+  throws(function() {
+    new BigInteger("deadbeef", 16).modPowInt(65537, BigInteger.ZERO);
+  },
+  "BigInteger divide by zero",
+  "reject mod(0)");
+});
+
 test("MessageDigest test", function() {
   expect(10);
   var md1 = new KJUR.crypto.MessageDigest({"alg": "sha1", "prov": "cryptojs"});
@@ -419,4 +444,3 @@ <h2 id="qunit-userAgent"></h2>
 </p>
 </body>
 </html>
-