Skip to content

Commit c4058cf

Browse files
authored
Make sure Chrome output when the listening line never appears
Make sure Chrome's output is available when the DEVTOOLS_LISTENING_LINE_PATTERN line doesn't appear and stdout doesn't close (eg. due to process closing) within the startup wait time. Before this change, the ChromeProcessTimeoutException would contain an empty Chrome output string in the case described above.
1 parent 1f222e5 commit c4058cf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cdt-java-client/src/main/java/com/github/kklisura/cdt/launch/ChromeLauncher.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,11 @@ private int waitForDevToolsServer(final Process process) throws ChromeProcessTim
345345
chromeOutputBuilder.append(System.lineSeparator());
346346
}
347347
chromeOutputBuilder.append(line);
348+
chromeOutput.set(chromeOutputBuilder.toString());
348349
}
349350
} catch (Exception e) {
350351
LOGGER.error("Failed while waiting for dev tools server.", e);
351352
} finally {
352-
chromeOutput.set(chromeOutputBuilder.toString());
353353
closeQuietly(reader);
354354
}
355355
});

0 commit comments

Comments
 (0)