Added custom serialize_object method to ScriptExecution to omit the data field

* Black formatting

Author: kkthxbye-code

netbox_script_manager/api/serializers.py

@@ -50,6 +50,29 @@ class Meta:
         )
 
 
+class NestedScriptInstanceSerializer(NetBoxModelSerializer):
+    url = serializers.HyperlinkedIdentityField(view_name="plugins-api:netbox_script_manager-api:scriptinstance-detail")
+    name = serializers.CharField(required=True)
+
+    class Meta:
+        read_only_fields = ["module_path", "class_name"]
+        model = ScriptInstance
+        fields = (
+            "id",
+            "url",
+            "name",
+            "group",
+            "weight",
+            "module_path",
+            "class_name",
+            "display",
+            "task_queues",
+            "tags",
+            "created",
+            "last_updated",
+        )
+
+
 class ScriptExecutionSerializer(NetBoxModelSerializer):
     url = serializers.HyperlinkedIdentityField(view_name="plugins-api:netbox_script_manager-api:scriptexecution-detail")
     script_instance = ScriptInstanceSerializer(read_only=True)

netbox_script_manager/api/views.py

@@ -35,7 +35,7 @@ class ScriptInstanceViewSet(NetBoxModelViewSet):
     queryset = ScriptInstance.objects.all()
     serializer_class = ScriptInstanceSerializer
     filterset_class = ScriptInstanceFilterSet
-    http_method_names = ['get', 'patch', 'delete']
+    http_method_names = ["get", "patch", "delete"]
 
     @action(detail=True, methods=["post"])
     def run(self, request, pk):

netbox_script_manager/models.py

@@ -1,11 +1,13 @@
 import importlib
+import json
 import threading
 from functools import cached_property
 
 import django_rq
 from django.conf import settings
 from django.contrib.auth.models import User
 from django.contrib.postgres.fields import ArrayField
+from django.core import serializers
 from django.core.validators import MinValueValidator
 from django.db import models
 from django.urls import reverse
@@ -151,6 +153,18 @@ def delete(self, *args, **kwargs):
         if task:
             task.cancel()
 
+    def serialize_object(obj, resolve_tags=True, extra=None):
+        """
+        While the netbox serialize_object claims to support excluding fields, it doesn't in reality.
+        """
+        json_str = serializers.serialize("json", [obj])
+        data = json.loads(json_str)[0]["fields"]
+
+        # Don't serialize the data field as it can be quite large
+        data.pop("data")
+
+        return data
+
     @property
     def duration(self):
         start_time = self.started or self.created

netbox_script_manager/views.py

@@ -202,14 +202,20 @@ class ScriptExecutionObjectChangeView(generic.ObjectChildrenView):
     template_name = "netbox_script_manager/script_execution_objectchange_list.html"
     tab = ViewTab(
         label="Changes",
-        badge=lambda obj: ObjectChange.objects.filter(request_id=str(obj.request_id)).exclude(changed_object_type=ContentType.objects.get_for_model(ScriptExecution)).count(),
+        badge=lambda obj: ObjectChange.objects.filter(request_id=str(obj.request_id))
+        .exclude(changed_object_type=ContentType.objects.get_for_model(ScriptExecution))
+        .count(),
         permission="netbox_script_manager.view_scriptexecution",
         weight=500,
         hide_if_empty=False,
     )
 
     def get_children(self, request, parent):
-        return ObjectChange.objects.restrict(request.user, "view").filter(request_id=str(parent.request_id)).exclude(changed_object_type=ContentType.objects.get_for_model(ScriptExecution))
+        return (
+            ObjectChange.objects.restrict(request.user, "view")
+            .filter(request_id=str(parent.request_id))
+            .exclude(changed_object_type=ContentType.objects.get_for_model(ScriptExecution))
+        )
 
 
 @register_model_view(models.ScriptExecution, "data")