Refactor RedisAdapter configuration handling.

Centralize RedisAdapter configuration by passing config parameters directly via constructor. Simplify initialization logic and update service definitions to use consistent parameter references for Redis settings.

Author: klapaudius

src/DependencyInjection/KlpMcpServerExtension.php

@@ -22,6 +22,9 @@ public function load(array $configs, ContainerBuilder $container): void
         $container->setParameter('klp_mcp_server.middlewares', $config['middlewares']);
         $container->setParameter('klp_mcp_server.provider', 'klp_mcp_server.provider.'.$config['server_provider']);
         $container->setParameter('klp_mcp_server.adapter', 'klp_mcp_server.adapter.'.$config['sse_adapter']);
+        $container->setParameter('klp_mcp_server.adapters.redis.prefix', $config['adapters']['redis']['prefix']);
+        $container->setParameter('klp_mcp_server.adapters.redis.connection', $config['adapters']['redis']['connection']);
+        $container->setParameter('klp_mcp_server.adapters.redis.ttl', $config['adapters']['redis']['ttl']);
         $container->setParameter('klp_mcp_server.tools', $config['tools']);
         $container->setParameter('klp_mcp_server.prompts', $config['prompts']);
         $container->setParameter('klp_mcp_server.resources', $config['resources']);

src/Resources/config/packages/klp_mcp_server.yaml

@@ -44,7 +44,7 @@ klp_mcp_server:
         in_memory: {}
         redis:
             prefix: 'mcp_sse_'
-            connection: '%env(MCP_REDIS_CONNECTION)' # database.php redis
+            connection: 'localhost' # change it as needed
             ttl: 100
         # Add more adapter configurations as needed
 

src/Resources/config/services.xml

@@ -19,6 +19,11 @@
 
         <service id="klp_mcp_server.adapter.default" alias="klp_mcp_server.adapter.redis" />
         <service id="klp_mcp_server.adapter.redis" class="KLP\KlpMcpServer\Transports\SseAdapters\RedisAdapter">
+            <argument type="collection">
+                <argument key="prefix">%klp_mcp_server.adapters.redis.prefix%</argument>
+                <argument key="connection">%klp_mcp_server.adapters.redis.connection%</argument>
+                <argument key="ttl">%klp_mcp_server.adapters.redis.ttl%</argument>
+            </argument>
             <argument type="service" id="logger" on-invalid="null" />
         </service>
         <service id="klp_mcp_server.transport.sse" class="KLP\KlpMcpServer\Transports\SseTransport">

src/Transports/SseAdapters/RedisAdapter.php

@@ -16,6 +16,7 @@
  */
 final class RedisAdapter implements SseAdapterInterface
 {
+    const FAILED_TO_INITIALIZE = 'Failed to initialize Redis SSE Adapter: ';
     /**
      * Redis connection instance
      */
@@ -32,33 +33,18 @@ final class RedisAdapter implements SseAdapterInterface
     protected int $messageTtl = 100;
 
     public function __construct(
+        private readonly array $config,
         private readonly ?LoggerInterface $logger
-    ) {}
-
-    /**
-     * Initialize the adapter with any required configuration
-     *
-     * @param  array  $config  Configuration options for the adapter
-     *
-     * @throws Exception If initialization fails
-     */
-    public function initialize(array $config): void
-    {
+    ) {
         try {
-            $connection = $config['connection'] ?? 'default';
+            $this->keyPrefix = $this->config['prefix'] ?? 'mcp_sse_';
+            $this->messageTtl = (int)$this->config['ttl'] ?: 100;
             $this->redis = new Redis;
-            $this->redis->connect('localhost', 6379);
-
-            if (isset($config['prefix'])) {
-                $this->keyPrefix = $config['prefix'];
-            }
-
-            if (isset($config['ttl'])) {
-                $this->messageTtl = (int) $config['ttl'];
-            }
+            $this->redis->connect($this->config['connection'], 6379);
+            $this->redis->setOption(Redis::OPT_PREFIX, $this->keyPrefix);
         } catch (Exception $e) {
-            $this->logger?->error('Failed to initialize Redis SSE Adapter: '.$e->getMessage());
-            throw new Exception('Failed to initialize Redis SSE Adapter: '.$e->getMessage());
+            $this->logger?->error(self::FAILED_TO_INITIALIZE .$e->getMessage());
+            throw new \Exception(self::FAILED_TO_INITIALIZE .$e->getMessage());
         }
     }
 

src/Transports/SseAdapters/SseAdapterInterface.php

@@ -67,13 +67,4 @@ public function hasMessages(string $clientId): bool;
      * @return int The number of messages
      */
     public function getMessageCount(string $clientId): int;
-
-    /**
-     * Initialize the adapter with any required configuration
-     *
-     * @param  array  $config  Configuration options for the adapter
-     *
-     * @throws \Exception If initialization fails
-     */
-    public function initialize(array $config): void;
 }