Refactor MakeMcpToolCommand error handling and add exception

Introduced MakeMcpToolCommandException to improve error handling in MakeMcpToolCommand. Replaced direct error messages with exceptions for better encapsulation and readability. Removed unused parameters in KlpMcpServerExtension and updated tool registration logic to enhance reliability.

Author: klapaudius

src/Command/MakeMcpToolCommand.php

@@ -2,6 +2,7 @@
 
 namespace KLP\KlpMcpServer\Command;
 
+use KLP\KlpMcpServer\Exceptions\MakeMcpToolCommandException;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
@@ -212,50 +213,44 @@ protected function detectYamlIndentation(string $content): int
      */
     protected function registerToolInConfig(string $toolClassName): bool
     {
-        $configPath = $this->kernel->getProjectDir().'/config/packages/klp_mcp_server.yaml';
-
-        if (! $this->files->exists($configPath)) {
-            $this->io->error("Config file not found: {$configPath}");
-
-            return false;
-        }
-
-        $content = $this->files->readFile($configPath);
-
-        // Find the tools array in the config file
-        if (! preg_match('/(tools:\s*(\s*-\s*[[:alnum:]\\\\]*|\[\]))/s', $content, $matches)) {
-            $this->io->error('Could not locate tools array in config file.');
+        try {
+            $configPath = $this->kernel->getProjectDir().'/config/packages/klp_mcp_server.yaml';
 
-            return false;
-        }
+            if (! $this->files->exists($configPath)) {
+                throw new MakeMcpToolCommandException("Config file not found: {$configPath}");
+            }
 
-        $toolsArrayContent = $matches[1];
+            $content = $this->files->readFile($configPath);
 
-        // Detect the indentation level used in the YAML file
-        $indentation = $this->detectYamlIndentation($content);
-        $indentStr = str_repeat(' ', $indentation);
-        $fullEntry = "\n{$indentStr}- {$toolClassName}";
+            // Find the tools array in the config file
+            if (! preg_match('/(tools:\s*(\s*-\s*[[:alnum:]\\\\]*|\[\]))/s', $content, $matches)) {
+                throw new MakeMcpToolCommandException('Could not locate tools array in config file.');
+            }
 
-        // Check if the tool is already registered
-        if (str_contains($toolsArrayContent, $toolClassName)) {
-            $this->io->info('Tool is already registered in config file.');
+            $toolsArrayContent = $matches[1];
 
-            return true;
-        }
+            // Detect the indentation level used in the YAML file
+            $indentation = $this->detectYamlIndentation($content);
+            $indentStr = str_repeat(' ', $indentation);
+            $fullEntry = "\n{$indentStr}- {$toolClassName}";
 
-        // Add the new tool to the tools array
-        $newToolsArrayContent = $toolsArrayContent.$fullEntry;
-        $newContent = str_replace($toolsArrayContent, $newToolsArrayContent, $content);
-        $newContent = str_replace('tools: []', 'tools:', $newContent);
+            // Check if the tool is already registered
+            if (str_contains($toolsArrayContent, $toolClassName)) {
+                $this->io->info('Tool is already registered in config file.');
+            } else {
+                // Add the new tool to the tools array
+                $newToolsArrayContent = $toolsArrayContent . $fullEntry;
+                $newContent = str_replace($toolsArrayContent, $newToolsArrayContent, $content);
+                $newContent = str_replace('tools: []', 'tools:', $newContent);
 
-        // Write the updated content back to the config file
-        try {
-            $this->files->dumpFile($configPath, $newContent);
-            $this->io->info('Tool registered successfully in config/packages/klp_mcp_server.yml');
+                // Write the updated content back to the config file
+                $this->files->dumpFile($configPath, $newContent);
+                $this->io->info('Tool registered successfully in config/packages/klp_mcp_server.yml');
+            }
 
             return true;
-        } catch (\Throwable) {
-            $this->io->error('Failed to update config file. Please manually register the tool.');
+        } catch (\Throwable $e) {
+            $this->io->error("Failed to update config file: {$e->getMessage()}");
 
             return false;
         }

src/DependencyInjection/KlpMcpServerExtension.php

@@ -27,7 +27,5 @@ public function load(array $configs, ContainerBuilder $container): void
         $container->setParameter('klp_mcp_server.adapters.redis.host', $config['adapters']['redis']['host'] ?? 'default');
         $container->setParameter('klp_mcp_server.adapters.redis.ttl', $config['adapters']['redis']['ttl'] ?? 100);
         $container->setParameter('klp_mcp_server.tools', $config['tools']);
-        //        $container->setParameter('klp_mcp_server.prompts', $config['prompts']);
-        //        $container->setParameter('klp_mcp_server.resources', $config['resources']);
     }
 }

src/Exceptions/MakeMcpToolCommandException.php

@@ -0,0 +1,5 @@
+<?php
+
+namespace KLP\KlpMcpServer\Exceptions;
+
+class MakeMcpToolCommandException extends \Exception {}