Skip to content

Commit 0549a46

Browse files
committed
change ignore to Test.hp classes
1 parent 50f92cd commit 0549a46

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

.github/workflows/testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
sed -i 's/Drupal.Classes.ClassCreateInstance/SlevomatCodingStandard.ControlStructures.NewWithParentheses/g' phpcs.xml.dist
8787
sed -i 's/Drupal.Classes.UnusedUseStatement/SlevomatCodingStandard.Namespaces.UnusedUses/g' phpcs.xml.dist
8888
sed -i '/<rule ref="SlevomatCodingStandard.Exceptions.RequireNonCapturingCatch" \/>/a \ <rule ref="SlevomatCodingStandard.Namespaces.UseFromSameNamespace"/>' phpcs.xml.dist
89-
sed -i 's/Drupal.Classes.ClassFileName/Squiz.Classes.ClassFileName/g' phpcs.xml.dist
89+
sed -i 's|<rule ref="Drupal.Classes.ClassFileName"/>|<rule ref="Squiz.Classes.ClassFileName">\n <!-- Disable class name to file name matching for *Test.php files. -->\n <exclude-pattern>*/tests/*/*Test.php</exclude-pattern>\n </rule>|' phpcs.xml.dist
9090
find . -type f -name "*.php" -exec sed -i 's#// phpcs:ignore Drupal.Classes.PropertyDeclaration, Drupal.NamingConventions.ValidVariableName.LowerCamelName, Drupal.Commenting.VariableComment.Missing#// phpcs:ignore Drupal.NamingConventions.ValidVariableName.LowerCamelName,PSR2.Classes.PropertyDeclaration.Underscore#g' {} +
9191
find . -type f -name "*.php" -exec sed -i 's#// @codingStandardsIgnoreLine#// phpcs:ignore#g' {} +
9292
find . -type f -name "*.php" -exec sed -i 's#// @codingStandardsIgnoreFile#// phpcs:ignoreFile#g' {} +

coder_sniffer/Drupal/ruleset.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,10 @@
186186

187187
<rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
188188

189-
<rule ref="Squiz.Classes.ClassFileName"/>
189+
<rule ref="Squiz.Classes.ClassFileName">
190+
<!-- Disable class name to file name matching in Test files. -->
191+
<exclude-pattern>*/tests/*/*Test.php</exclude-pattern>
192+
</rule>
190193
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration"/>
191194
<!-- Disable some error messages that we already cover. -->
192195
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower">
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<?php
2+
3+
/**
4+
* Class names not matching the file name are allowed in *Test.php files.
5+
*/
6+
class CompletelyDifferentName {}

0 commit comments

Comments
 (0)